Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list set (union, difference) commands #221

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

JesseWeinstein
Copy link
Contributor

This is useful for creating a pair of lists, one of which contains accounts you want to only look at irregularly, and the other containing everyone else you follow. You can do so by first doing a union of all your followers (using the "[following]" magic name) then doing a difference with the list of accounts to exclude.

I'm very open to suggestions about a better way to achieve this, but wanted to make it available in case it is of interest.

src/tootstream/toot.py Outdated Show resolved Hide resolved
src/tootstream/toot.py Outdated Show resolved Hide resolved
@JesseWeinstein JesseWeinstein mentioned this pull request Dec 27, 2022
@craigmaloney
Copy link
Collaborator

I've given this some thought. I'm not 100% convinced of the utility of the list commands in here. Would it be possible to split off the configuration and follow changes into a separate pull request so we can discuss these separately? It's not that I'm opposed to the new commands, I'm just not sure they're something to add quite yet.

Thanks!

@craigmaloney craigmaloney self-requested a review December 31, 2022 03:55
@JesseWeinstein
Copy link
Contributor Author

Sure, I'll make a separate PR with the fetch_remaining (which probably should be applied to a few other places, too) changes and I'll toss in the get_mastodon change. Should probably be able to make it today.

@JesseWeinstein
Copy link
Contributor Author

Regarding the new list commands, while I think the use I'm making of them (to make a all-followers-except-a-list list) is good, I'm also not sure if this is the right way to expose that functionality. Glad for any further thoughts you have about them.

@JesseWeinstein
Copy link
Contributor Author

Actually, I'm just going to rebase my other cleanup PR, #222, back on develop, and merge in the non-new-commands changes into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants