Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DIRECTORY_SEPARATOR replacement in regular expression #419

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

fredden
Copy link
Contributor

@fredden fredden commented Sep 27, 2023

Fixes #416

This change doesn't break any existing tests, including mutations.

@Ocramius Ocramius added the bug label Sep 27, 2023
@Ocramius Ocramius added this to the 4.7.1 milestone Sep 27, 2023
@Ocramius Ocramius changed the base branch from 4.8.x to 4.7.x September 27, 2023 14:53
@Ocramius Ocramius self-assigned this Sep 27, 2023
Copy link
Collaborator

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fredden!

@Ocramius Ocramius merged commit e49c58b into maglnet:4.7.x Sep 27, 2023
23 checks passed
@Ocramius Ocramius changed the title Remove DIRECTORY_SEPARATOR replacement in regular expression Remove DIRECTORY_SEPARATOR replacement in regular expression Sep 27, 2023
@fredden fredden deleted the issue-416/windows-paths-preg_quote branch September 27, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning: preg_match(): Compilation failed: unrecognized character
2 participants