Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set vike minimum version to 0.4.213 #133

Closed
wants to merge 3 commits into from

Conversation

rtritto
Copy link
Contributor

@rtritto rtritto commented Jan 15, 2025

Update Vike to minimum version 0.4.213

Related warning:

21:48:02 [vike][Warning] import { prerender } from 'vike/prerender' is deprecated in favor of import { prerender } from 'vike/api'
    at file:///C:/<PROJECT>/.yarn/__virtual__/vike-virtual-b46c09d88d/4/Users/<USER>/AppData/Local/Yarn/Berry/cache/vike-npm-0.4.215-2c9f246c79-10c0.zip/node_modules/vike/dist/esm/node/prerender/index.js:5:1
    at tryImportVpvv (file:///C:/<PROJECT>/.yarn/__virtual__/vite-plugin-vercel-virtual-183eab8f42/4/Users/<USER>/AppData/Local/Yarn/Berry/cache/vite-plugin-vercel-npm-9.0.4-35c2fd45b3-10c0.zip/node_modules/vite-plugin-vercel/dist/index.js:779:18)
    at async Promise.all (index 41)
    at asyncFlatten (file:///C:/<PROJECT>/.yarn/__virtual__/vite-virtual-56a392082f/4/Users/<USER>/AppData/Local/Yarn/Berry/cache/vite-npm-6.0.7-8c24f1f180-10c0.zip/node_modules/vite/dist/node/chunks/dep-BJP6rrE_.js:10411:12)
    at resolveConfig (file:///C:/<PROJECT>/.yarn/__virtual__/vite-virtual-56a392082f/4/Users/<USER>/AppData/Local/Yarn/Berry/cache/vite-npm-6.0.7-8c24f1f180-10c0.zip/node_modules/vite/dist/node/chunks/dep-BJP6rrE_.js:53310:23)
    at resolveViteConfig (file:///C:/<PROJECT>/.yarn/__virtual__/vike-virtual-b46c09d88d/4/Users/<USER>/AppData/Local/Yarn/Berry/cache/vike-npm-0.4.215-2c9f246c79-10c0.zip/node_modules/vike/dist/esm/node/api/prepareApiCall.js:31:12)
    at enhanceViteConfig (file:///C:/<PROJECT>/.yarn/__virtual__/vike-virtual-b46c09d88d/4/Users/<USER>/AppData/Local/Yarn/Berry/cache/vike-npm-0.4.215-2c9f246c79-10c0.zip/node_modules/vike/dist/esm/node/api/prepareApiCall.js:11:30)
    at Module.dev (file:///C:/<PROJECT>/.yarn/__virtual__/vike-virtual-b46c09d88d/4/Users/<USER>/AppData/Local/Yarn/Berry/cache/vike-npm-0.4.215-2c9f246c79-10c0.zip/node_modules/vike/dist/esm/node/api/dev.js:5:36)
    at cmdDev (file:///C:/<PROJECT>/.yarn/__virtual__/vike-virtual-b46c09d88d/4/Users/<USER>/AppData/Local/Yarn/Berry/cache/vike-npm-0.4.215-2c9f246c79-10c0.zip/node_modules/vike/dist/esm/node/cli/entry.js:24:32)
    at cli (file:///C:/<PROJECT>/.yarn/__virtual__/vike-virtual-b46c09d88d/4/Users/<USER>/AppData/Local/Yarn/Berry/cache/vike-npm-0.4.215-2c9f246c79-10c0.zip/node_modules/vike/dist/esm/node/cli/entry.js:9:9)

Copy link

vercel bot commented Jan 15, 2025

@rtritto is attempting to deploy a commit to the magne4000 Team on Vercel.

A member of the Team first needs to authorize it.

@rtritto
Copy link
Contributor Author

rtritto commented Jan 17, 2025

Conflicts resolved, ready for merge

Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
test-vite-vercel-plugin ❌ Failed (Inspect) Jan 18, 2025 9:56am

@brillout
Copy link
Contributor

The CI is failing. I'll have a look at it beginning of next week.

@rtritto
Copy link
Contributor Author

rtritto commented Jan 19, 2025

Maybe is related to some breaking change in vike version > 0.4.213 and <= 0.4.217

@brillout
Copy link
Contributor

@magne4000 Let's close this in favor of #137. (I don't have to permission to close this PR.)

@rtritto rtritto closed this Jan 24, 2025
@rtritto rtritto deleted the vike-0.4.213 branch January 24, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants