Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bioenergy Demand and GHG Price trajectories #621

Merged
merged 15 commits into from
Jan 8, 2024

Conversation

flohump
Copy link
Contributor

@flohump flohump commented Jan 3, 2024

🐦 Description of this PR 🐦

  • Briefly explain the purpose of this pull request

🔧 Checklist for PR creator 🔧

  • Label pull request from the label list.

    • Low risk: Simple bugfixes (missing files, updated documentation, typos) or changes in start or output scripts
    • Medium risk: Uncritical changes in the model core (e.g. moderate modifications in non-default realizations)
    • High risk: Critical changes in model core or default settings (e.g. changing a model default or adjusting a core mechanic in the model)
  • Self-review own code

    • No hard coded numbers and cluster/country/region names.
    • The new code doesn't contain declared but unused parameters or variables.
    • magpie4 R library has been updated accordingly and backwards compatible where necessary.
    • scenario_config.csv has been updated accordingly (important if default.cfg has been updated)
  • Document changes

    • Add changes to CHANGELOG.md
    • Where relevant, put In-code documentation comments
    • Properly address updates in interfaces in the module documentations
    • run goxygen::goxygen() and verify the modified code is properly documented
  • Perform test runs

    • Low risk:
      • Run a compilation check via Rscript start.R --> "compilation check"
    • Medium risk:
      • Run test runs via Rscript start.R --> "test runs"
      • Check logs for errors/warnings
    • High risk:
      • Run test runs via Rscript start.R --> "test runs"
      • Check logs for errors/warnings
      • Default run from the PR target branch for comparison
      • Provide relevant comparison plots (land-use, emissions, food prices, land-use intensity,...)

Resources_Land_Cover_Cropland-94
Productivity_Landuse_Intensity_Indicator_Tau-82
Emissions_CO2_Land_Land_use_Change-81
Demand_Bioenergy_2nd_generation-11
Prices_GHG_Emission_CO2_Secondary_Forest_Vegetation_carbon

📉 Performance changes 📈

  • Current develop branch default : 24 mins
  • This PR's default : 24 mins

🚨 Checklist for reviewer 🚨

  • PR is labeled correctly
  • Code changes look reasonable
    • No hard coded numbers and cluster/country/region names.
    • No unnecessary increase in module interfaces
    • model behavior/performance is satisfactory.
  • Changes are properly documented
    • CHANGELOG is updated correctly
    • Updates in interfaces have been properly addressed in the module documentations
    • In-code documentation looks appropriate
  • content review done (at least 1)
  • RSE review done (at least 1)

@flohump flohump requested a review from dklein-pik January 4, 2024 14:28
config/default.cfg Outdated Show resolved Hide resolved
config/default.cfg Outdated Show resolved Hide resolved
config/default.cfg Outdated Show resolved Hide resolved
flohump and others added 3 commits January 5, 2024 16:25
Co-authored-by: David Klein <[email protected]>
Co-authored-by: David Klein <[email protected]>
Co-authored-by: David Klein <[email protected]>
@flohump flohump requested a review from tscheypidi January 5, 2024 15:26
@flohump flohump added Medium risk enhancement New feature or request labels Jan 5, 2024
@flohump flohump marked this pull request as ready for review January 6, 2024 09:38
@flohump flohump merged commit 25899d4 into magpiemodel:develop Jan 8, 2024
1 check passed
FelicitasBeier added a commit to flohump/magpie that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Medium risk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants