revision of SCP implementation for milk and meat alternatives #698

flohump · 2024-07-12T08:04:14Z

🐦 Description of this PR 🐦

15_food revision of MP/SCP implementation for milk and meat alternatives. Added demand for fat and sugar as ingredients for MP-based milk alternatives. Added optional demand for fat as ingredient for MP-based meat alternatives.

🔧 Checklist for PR creator 🔧

Label pull request from the label list.
- Low risk: Simple bugfixes (missing files, updated documentation, typos) or changes in start or output scripts
- Medium risk: Uncritical changes in the model core (e.g. moderate modifications in non-default realizations)
- High risk: Critical changes in model core or default settings (e.g. changing a model default or adjusting a core mechanic in the model)
Self-review own code
- No hard coded numbers and cluster/country/region names.
- The new code doesn't contain declared but unused parameters or variables.
- magpie4 R library has been updated accordingly and backwards compatible where necessary.
- scenario_config.csv has been updated accordingly (important if default.cfg has been updated)
Document changes
- Add changes to CHANGELOG.md
- Where relevant, put In-code documentation comments
- Properly address updates in interfaces in the module documentations
- run goxygen::goxygen() and verify the modified code is properly documented
Perform test runs
- Low risk:
  - Run a compilation check via Rscript start.R --> "compilation check"
- Medium risk:
  - Run test runs via Rscript start.R --> "test runs"
  - Check logs for errors/warnings
- High risk:
  - Run test runs via Rscript start.R --> "test runs"
  - Check logs for errors/warnings
  - Default run from the PR target branch for comparison
  - Provide relevant comparison plots (land-use, emissions, food prices, land-use intensity,...)

📉 Performance changes 📈

Current develop branch default : ** mins
This PR's default : ** mins

🚨 Checklist for reviewer 🚨

PR is labeled correctly
Code changes look reasonable
- No hard coded numbers and cluster/country/region names.
- No unnecessary increase in module interfaces
- model behavior/performance is satisfactory.
Changes are properly documented
- CHANGELOG is updated correctly
- Updates in interfaces have been properly addressed in the module documentations
- In-code documentation looks appropriate
content review done (at least 1)
RSE review done (at least 1)

…ional demand.

slovat · 2024-07-12T08:18:56Z

modules/15_food/anthro_iso_jun22/declarations.gms

+ s15_scp_protein_per_milk protein needed as ingredient for scp milk (mass per 100g milk) / 3.3 /
+ s15_scp_fat_to_kcal conversion factor (kcal per gram of fat) / 8.79 /
+ s15_scp_sugar_to_kcal conversion factor (kcal per gram of sugar) / 3.87 /
+ s15_scp_protein_to_kcal conversion factor (kcal per gram of protein) / 4.27 /


s15_scp_fat_to_kcal , s15_scp_sugar_to_kcal, s15_scp_protein_to_kcal these are the specific conversion factors for milk. It would be worth clarifying this in the scalar name. If demand for sugar and oil is also implemented for meat, then this too would have a specific caloric conversion factors that are different from milk.

tscheypidi

Just one comment concerning the used units where a different unit and/or a better unit description could be helpful

tscheypidi · 2024-07-12T08:16:25Z

modules/15_food/anthro_iso_jun22/declarations.gms

@@ -183,7 +184,12 @@ parameters
 ;

 scalars
- s15_year          Current year as integer value (yr)  / 2000 /
+ s15_scp_fat_per_milk fat needed as ingredient for scp milk (mass per 100g milk) / 3.3 /


I don't understand the unit. Is it g/100g ?! Why not just a mass ratio (1:1)?

slovat

Just one small comment regarding the naming of s15_scp_fat_to_kcal , s15_scp_sugar_to_kcal and s15_scp_protein_to_kcal, these are specific to milk, it would be worth clarifying this in their names

weindl · 2024-07-15T08:43:07Z

CHANGELOG.md

@@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 ### changed
 - **21_trade** refactor equations for enhanced readablility and improve documentation
 - **script** rewrite of merge_report.R based on rds files and rbind, which allows for more flexibility when merging reports. Avoid inconsistent use of "GLO" instead of "World" in report.rds files.
+- **15_food** revision of SCP implementation for milk. Added demand for plant oil and sugar as ingredients for milk production using single cell protein.


Suggestion:
"milk production" --> "(animal-free) milk alternative" or similar?

weindl · 2024-07-15T08:59:41Z

modules/15_food/anthro_iso_jun22/declarations.gms

+ s15_scp_fat_per_milk fat needed as ingredient for scp milk (g per 100g) / 3.3 /
+ s15_scp_sugar_per_milk sugar needed as ingredient for scp milk (g per 100g) / 4.7 /
+ s15_scp_protein_per_milk protein needed as ingredient for scp milk (g per 100g) / 3.3 /
+ s15_scp_fat_to_kcal_milk conversion factor (kcal per gram of fat) / 8.79 /
+ s15_scp_sugar_to_kcal_milk conversion factor (kcal per gram of sugar) / 3.87 /
+ s15_scp_protein_to_kcal_milk conversion factor (kcal per gram of protein) / 4.27 /
 ;


Please also add information regarding dry or wet matter basis.

weindl · 2024-07-15T08:59:51Z

modules/15_food/anthropometrics_jan18/declarations.gms

+ s15_scp_fat_per_milk fat needed as ingredient for scp milk (g per 100g) / 3.3 /
+ s15_scp_sugar_per_milk sugar needed as ingredient for scp milk (g per 100g) / 4.7 /
+ s15_scp_protein_per_milk protein needed as ingredient for scp milk (g per 100g) / 3.3 /
+ s15_scp_fat_to_kcal_milk conversion factor (kcal per gram of fat) / 8.79 /
+ s15_scp_sugar_to_kcal_milk conversion factor (kcal per gram of sugar) / 3.87 /
+ s15_scp_protein_to_kcal_milk conversion factor (kcal per gram of protein) / 4.27 /


Please also add information regarding dry or wet matter basis.

weindl · 2024-07-15T09:22:18Z

modules/15_food/anthro_iso_jun22/exodietmacro.gms

+*' Reduction of ruminant meat and dairy products (kfo_rd):
+p15_kcal_pc_iso(t,iso,kfo_rd) = p15_kcal_pc_iso(t,iso,kfo_rd) * i15_rumdairy_scp_fadeout(t,iso);
+*'
+*' Plant oil and sugar demands as ingredients for milk production using single cell protein 


Suggestion:
"milk production" --> "(animal-free) milk alternative" or similar?

weindl · 2024-07-15T09:22:30Z

modules/15_food/anthropometrics_jan18/intersolve.gms

 p15_kcal_pc_calibrated(t,i,kfo_rd) = p15_kcal_pc_calibrated(t,i,kfo_rd) * i15_rumdairy_scp_fadeout(t,i);
-
+*'
+*' Plant oil and sugar demands as ingredients for milk production using single cell protein 


Suggestion:
"milk production" --> "(animal-free) milk alternative" or similar?

weindl · 2024-07-15T09:22:41Z

modules/15_food/anthropometrics_jan18/presolve.gms

 p15_kcal_pc_calibrated(t,i,kfo_rd) = p15_kcal_pc_calibrated(t,i,kfo_rd) * i15_rumdairy_scp_fadeout(t,i);
-
+*'
+*' Plant oil and sugar demands as ingredients for milk production using single cell protein 


Suggestion:
"milk production" --> "(animal-free) milk alternative" or similar?

weindl · 2024-07-15T11:27:30Z

modules/15_food/anthro_iso_jun22/exodietmacro.gms

+p15_kcal_pc_iso(t,iso,"oils") = p15_kcal_pc_iso(t,iso,"oils") 
+   + sum(kfo_rd$sameas(kfo_rd,"livst_milk"), p15_kcal_pc_iso_scp(t,iso,kfo_rd)) 
+   * (s15_scp_fat_per_milk * s15_scp_fat_to_kcal_milk) / (s15_scp_protein_per_milk * s15_scp_protein_to_kcal_milk);
+*'


I think '1/s15_scp_protein_to_kcal_milk' has to be replaced by 'i15_protein_to_kcal_ratio(t,"scp")' (the same for line 138 below).
The reference unit for replacement of milk with scp-milk is protein. Based on the estimation of how much scp-protein is needed to replace cow milk, we can calculate here, how much additional sugar and oil is required to create an "scp milk" with similar properties like cow milk.

Furthermore, I don't understand why the conversion factors for kcal per gram of fat and sugar should be specific for milk.

Thanks for your review!
If I understand correctly, we could do the following:
Instead of
p15_kcal_pc_calibrated_scp(t,i,kfo_rd) = p15_kcal_pc_calibrated(t,i,kfo_rd) * (1-i15_rumdairy_scp_fadeout(t,i)) * i15_protein_to_kcal_ratio(t,kfo_rd) / i15_protein_to_kcal_ratio(t,"scp");
we could do
p15_protein_pc_calibrated_scp(t,i,kfo_rd) = p15_kcal_pc_calibrated(t,i,kfo_rd) * (1-i15_rumdairy_scp_fadeout(t,i)) * i15_protein_to_kcal_ratio(t,kfo_rd);
Thus keeping the unit in protein.
This would also change this calculation of p15_kcal_pc_calibrated(t,i,"scp"):
p15_kcal_pc_calibrated(t,i,"scp") = p15_kcal_pc_calibrated(t,i,"scp") + sum(kfo_rd, p15_protein_pc_calibrated_scp(t,i,kfo_rd))/i15_protein_to_kcal_ratio(t,"scp");

This would simplify the addition of oil to:
p15_kcal_pc_calibrated(t,i,"oils") = p15_kcal_pc_calibrated(t,i,"oils") + sum(kfo_rd$sameas(kfo_rd,"livst_milk"), p15_protein_pc_calibrated_scp(t,i,kfo_rd)) / s15_scp_protein_per_milk * s15_scp_fat_per_milk;

For sugar:
p15_kcal_pc_calibrated(t,i,"sugar") = p15_kcal_pc_calibrated(t,i,"sugar") + sum(kfo_rd$sameas(kfo_rd,"livst_milk"), p15_protein_pc_calibrated_scp(t,i,kfo_rd)) / s15_scp_protein_per_milk * s15_scp_sugar_per_milk;

@slovat Do you follow here?

Not sure I completely understand. If I get it right, you are saying rather than going through kcal, work with mass of protein. Based on the mass of SCP milk protein produced, calculate the amount of fat and sugar demand then based on their mass ratio with protein in milk? I.e. if I produce 20 Mt milk protein and the mass ratio of protein to fat is 1:1, I would also need 20 Mt fat?

@weindl I'm not sure what's best to use for the conversion factors for kcal per gram of fat and sugar and what level of detail is usually used in MAgPIE. We could use a generic factor of 4 kcal/g protein or sugar and 9 kcal/g fat. But if I'm not mistaken, caloric densities reflect energy available for humans and this includes something about digestability. Because different food products have different digestabilities, a gram of sugar in say milk is different than in wheat and so there is different amounts available depending on the food product. This means there are specific caloric conversion factors for differnet food products (they don't vary hugely between different products), but if this is not normally done in MAgPIE, we can just use generic factors too.

Thanks @flohump Your suggestion looks good. The only thing I noticed: as long as the meaning of the scalars does not chnage, we still need 's15_scp_fat_to_kcal_milk' and 's15_scp_sugar_to_kcal_milk' to convert mass to kcal, as required by e.g. 'p15_kcal_pc_calibrated(t,i,"oils")'.

@flohump In general, your approach makes sense to me, but the sugar and fat equations need an additional factor at the end translating g sugar / fat to kcal. Right now, equation units would be
kcal = kcal + g protein / (g protein / 100 g milk) * g fat / 100 g milk = kcal + g fat (or g sugar, respectively)

p15_kcal_pc_calibrated(t,i,"oils") = p15_kcal_pc_calibrated(t,i,"oils") + sum(kfo_rd$sameas(kfo_rd,"livst_milk"), p15_protein_pc_calibrated_scp(t,i,kfo_rd)) / s15_scp_protein_per_milk * s15_scp_fat_per_milk * fm_nutrition_attributes(t,"oils", "kcal");

p15_kcal_pc_calibrated(t,i,"sugar") = p15_kcal_pc_calibrated(t,i,"sugar") + sum(kfo_rd$sameas(kfo_rd,"livst_milk"), p15_protein_pc_calibrated_scp(t,i,kfo_rd)) / s15_scp_protein_per_milk * s15_scp_sugar_per_milk * fm_nutrition_attributes(t, "sugar" ,"kcal");

Few fine-tuning question: Are these sugar and fat amounts / 100g the ones that are consumed at the end or the amounts that go into the SCP production process, with different amounts actually consumed?

And is it important for reporting of food profiles that we're splitting a single category (milk) into three distinct ones (SCP, sugar, oils) instead of summing these values to a single SCP kcal value?

Edit: Ah, @weindl was faster. :)

Looks good now

jansteinhauser · 2024-07-15T15:00:36Z

modules/15_food/anthropometrics_jan18/presolve.gms

+p15_kcal_pc_calibrated(t,i,"sugar") = p15_kcal_pc_calibrated(t,i,"sugar") 
+   + sum(kfo_rd$sameas(kfo_rd,"livst_milk"), p15_kcal_pc_calibrated_scp(t,i,kfo_rd))
+   * (s15_scp_sugar_per_milk * s15_scp_sugar_to_kcal_milk) / (s15_scp_protein_per_milk * s15_scp_protein_to_kcal_milk);
+*'


Same changes necessary as in the other module.

jansteinhauser

See comment in exodietmacro.gms. Process makes sense to me, but the suggested equations seem to need unit checking.

weindl

Thank you for this version. Looks good!

weindl · 2024-07-16T13:45:38Z

modules/15_food/anthro_iso_jun22/exodietmacro.gms

+p15_kcal_pc_iso(t,iso,"oils") = p15_kcal_pc_iso(t,iso,"oils") 
+   + sum(kfo_rd$sameas(kfo_rd,"livst_milk"), p15_kcal_pc_iso_scp(t,iso,kfo_rd)) 
+   * (s15_scp_fat_per_milk * s15_scp_fat_to_kcal_milk) / (s15_scp_protein_per_milk * s15_scp_protein_to_kcal_milk);
+*'


Looks good now

jansteinhauser

Looks great, just one tiny description suggestion.

modules/15_food/anthro_iso_jun22/declarations.gms

modules/15_food/anthropometrics_jan18/declarations.gms

# Conflicts: # CHANGELOG.md

jansteinhauser

Please double check units

config/default.cfg

modules/15_food/anthro_iso_jun22/exodietmacro.gms

modules/15_food/anthro_iso_jun22/input.gms

modules/15_food/anthropometrics_jan18/input.gms

modules/15_food/anthropometrics_jan18/intersolve.gms

modules/15_food/anthropometrics_jan18/presolve.gms

flohump · 2024-07-22T09:33:43Z

I added reporting variables for oil and sugar as inredient for scp-based met and milk alternatives in the magpie4 R library: pik-piam/magpie4@0cd8574

weindl

The addition to the code looks good in general. I have only one comment to the naming of a new scalar.

weindl · 2024-07-22T09:51:19Z

modules/15_food/anthro_iso_jun22/declarations.gms

+ s15_scp_fat_per_milk               Fat needed as ingredient for scp-based milk alternative (g per 100g wet matter) / 3.3 /
+ s15_scp_sugar_per_milk             Sugar needed as ingredient for scp-based milk alternative (g per 100g wet matter) / 4.7 /
+ s15_scp_protein_per_milk           Protein needed as ingredient for scp-based milk alternative (g per 100g wet matter) / 3.3 /
+ s15_scp_fat_per_meat               Fat content of microbial biomass based on Solein from Solar foods (t fat per t DM) / 0.05 /


I suggest to rename the scalar 's15_scp_fat_per_meat' to better reflect its meaning ( ="fat content of microbial biomass).
For me 's15_scp_fat_per_meat' sounds like a scalar indicating how much fat is needed to produce a unit of final scp-meat product in wet matter, which is not the case.

Maybe 's15_scp_fat_content' or similar?

The renaming would also require changes in the magpie4.

Thanks for the suggestion. I revised the scalar name in the GAMS code and the magpie4 R library.

flohump added 3 commits July 10, 2024 15:27

Add oil and sugar needed as ingredient for MP/scp production as addit…

1460d2a

…ional demand.

partial commit to save work

7fb19d7

Add oil and sugar needed as ingredient for MP/scp production as addit…

3679f7d

…ional demand.

flohump added enhancement New feature or request Low risk Low risk labels Jul 12, 2024

flohump requested review from tscheypidi, weindl, jansteinhauser and slovat July 12, 2024 08:04

flohump added Medium risk and removed Low risk Low risk labels Jul 12, 2024

slovat reviewed Jul 12, 2024

View reviewed changes

tscheypidi approved these changes Jul 12, 2024

View reviewed changes

slovat approved these changes Jul 12, 2024

View reviewed changes

flohump added 2 commits July 15, 2024 09:44

revision of units and scalar names

691ec01

replace tabs with spaces

6907c61

weindl requested changes Jul 15, 2024

View reviewed changes

jansteinhauser reviewed Jul 15, 2024

View reviewed changes

jansteinhauser requested changes Jul 15, 2024

View reviewed changes

flohump added 2 commits July 16, 2024 15:00

revision scp-based milk

f7ea2a9

Merge branch 'develop' of github.com:magpiemodel/magpie into f_MP

d881fdf

flohump requested review from weindl and jansteinhauser July 16, 2024 13:16

weindl approved these changes Jul 16, 2024

View reviewed changes

jansteinhauser approved these changes Jul 16, 2024

View reviewed changes

modules/15_food/anthro_iso_jun22/declarations.gms Outdated Show resolved Hide resolved

modules/15_food/anthropometrics_jan18/declarations.gms Outdated Show resolved Hide resolved

flohump added 3 commits July 18, 2024 15:52

added optional fat for scp-based meat alternatives

dd74dd4

update

5002cd8

Merge branch 'develop' of github.com:magpiemodel/magpie into f_MP

ed254ca

# Conflicts: # CHANGELOG.md

jansteinhauser requested changes Jul 19, 2024

View reviewed changes

flohump changed the title ~~revision of SCP implementation for milk~~ revision of SCP implementation for milk and meat alternatives Jul 19, 2024

bugfix

13709ef

jansteinhauser approved these changes Jul 19, 2024

View reviewed changes

weindl requested changes Jul 22, 2024

View reviewed changes

rename

8901669

flohump requested a review from weindl July 22, 2024 10:32

weindl approved these changes Jul 22, 2024

View reviewed changes

flohump merged commit 92d984c into magpiemodel:develop Jul 23, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

revision of SCP implementation for milk and meat alternatives #698

revision of SCP implementation for milk and meat alternatives #698

flohump commented Jul 12, 2024 •

edited

Loading

slovat Jul 12, 2024

tscheypidi left a comment

tscheypidi Jul 12, 2024

slovat left a comment

weindl Jul 15, 2024

weindl Jul 15, 2024

weindl Jul 15, 2024

weindl Jul 15, 2024

weindl Jul 15, 2024

weindl Jul 15, 2024

weindl Jul 15, 2024

flohump Jul 15, 2024 •

edited

Loading

flohump Jul 15, 2024

slovat Jul 15, 2024

slovat Jul 15, 2024

weindl Jul 15, 2024

jansteinhauser Jul 15, 2024 •

edited

Loading

weindl Jul 16, 2024

jansteinhauser Jul 15, 2024

jansteinhauser left a comment

weindl left a comment

weindl Jul 16, 2024

jansteinhauser left a comment

jansteinhauser left a comment

flohump commented Jul 22, 2024

weindl left a comment

weindl Jul 22, 2024

weindl Jul 22, 2024

flohump Jul 22, 2024

revision of SCP implementation for milk and meat alternatives #698

revision of SCP implementation for milk and meat alternatives #698

Conversation

flohump commented Jul 12, 2024 • edited Loading

🐦 Description of this PR 🐦

🔧 Checklist for PR creator 🔧

📉 Performance changes 📈

🚨 Checklist for reviewer 🚨

Choose a reason for hiding this comment

tscheypidi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

slovat left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flohump Jul 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jansteinhauser Jul 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jansteinhauser left a comment

Choose a reason for hiding this comment

weindl left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jansteinhauser left a comment

Choose a reason for hiding this comment

jansteinhauser left a comment

Choose a reason for hiding this comment

flohump commented Jul 22, 2024

weindl left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flohump commented Jul 12, 2024 •

edited

Loading

flohump Jul 15, 2024 •

edited

Loading

jansteinhauser Jul 15, 2024 •

edited

Loading