Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #267: Memcached failover in non-sticky mode #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed #267: Memcached failover in non-sticky mode #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion core/src/main/java/de/javakaffee/web/msm/RequestTrackingHostValve.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ public void invoke( final Request request, final Response response ) throws IOEx
final String requestId = getURIWithQueryString( request );
if(!_enabled.get() || !_msmContext.equals(request.getContext())) {
getNext().invoke( request, response );
} else if ( _ignorePattern != null && _ignorePattern.matcher( requestId ).matches() ) {
} else if ( _ignorePattern != null && _ignorePattern.matcher( requestId ).matches() && isPrimaryMemcachedNodeIsAvailable(request)) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the check for primary node availability for ignored urls.

if(_log.isDebugEnabled()) {
_log.debug( ">>>>>> Ignoring: " + requestId + " (requestedSessionId "+ request.getRequestedSessionId() +") ==================" );
}
Expand Down Expand Up @@ -280,4 +280,11 @@ private void logDebugResponseCookie( final Response response ) {
}
}

private boolean isPrimaryMemcachedNodeIsAvailable(Request request) {
MemcachedNodesManager memcachedNodesManager = _sessionBackupService.getMemcachedNodesManager();
String primaryNodeIdentifier = memcachedNodesManager.getSessionIdFormat().extractMemcachedId(request.getRequestedSessionId());
/* In case we have no primary node identifier then primary node is definitely not available for the session */
return primaryNodeIdentifier == null ? false : memcachedNodesManager.isNodeAvailable(primaryNodeIdentifier);
}

}
32 changes: 32 additions & 0 deletions core/src/test/java/de/javakaffee/web/msm/RequestTrackingHostValveTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,18 @@
*/
public abstract class RequestTrackingHostValveTest {

private static final String PRIMARY_NODE_IDENTIFIER = "n2";
private static final boolean IS_PRIMARY_MEMCACHED_NODE_OPERATIONAL = true;
private static final String SESSION_ID = "9956461BA10903169EB0C4041DCA7BF1-n2";
private static final String REQUEST_IGNORED = "de.javakaffee.msm.request.ignored";

protected MemcachedSessionService _service;
private RequestTrackingHostValve _sessionTrackerValve;
private Valve _nextValve;
private Request _request;
private Response _response;
private MemcachedNodesManager _memcachedNodesManager;
private SessionIdFormat _sessionIdFormat;

@BeforeMethod
public void setUp() throws Exception {
Expand All @@ -75,6 +82,8 @@ public void setUp() throws Exception {
_nextValve = mock( Valve.class );
_sessionTrackerValve.setNext( _nextValve );
_sessionTrackerValve.setContainer(_hostContainer);
_memcachedNodesManager = mock( MemcachedNodesManager.class );
_sessionIdFormat = mock( SessionIdFormat.class );

when(_request.getRequestURI()).thenReturn( "/someRequest");
when(_request.getMethod()).thenReturn("GET");
Expand All @@ -83,6 +92,11 @@ public void setUp() throws Exception {

when(_request.getNote(eq(RequestTrackingHostValve.REQUEST_PROCESSED))).thenReturn(Boolean.TRUE);
when(_request.getNote(eq(RequestTrackingHostValve.SESSION_ID_CHANGED))).thenReturn(Boolean.FALSE);

when(_sessionIdFormat.extractMemcachedId(anyString())).thenReturn(PRIMARY_NODE_IDENTIFIER);
when(_service.getMemcachedNodesManager()).thenReturn(_memcachedNodesManager);
when(_memcachedNodesManager.isNodeAvailable(PRIMARY_NODE_IDENTIFIER)).thenReturn(IS_PRIMARY_MEMCACHED_NODE_OPERATIONAL);
when(_memcachedNodesManager.getSessionIdFormat()).thenReturn(_sessionIdFormat);
}

@Nonnull
Expand Down Expand Up @@ -176,6 +190,24 @@ public final void testRequestFinishedShouldBeInvokedForIgnoredResources() throws
verify( _service ).requestFinished( eq( "foo" ), anyString() );
}

@Test
public final void testRequestUrlIgnorePatternIsSkippedIfPrimaryMemcachedNodeIsDown() throws IOException, ServletException {
when(_memcachedNodesManager.isNodeAvailable(PRIMARY_NODE_IDENTIFIER)).thenReturn(false);
when(_request.getRequestedSessionId()).thenReturn(SESSION_ID);
_sessionTrackerValve.invoke( _request, _response );

verify( _request ).setNote(RequestTrackingHostValve.REQUEST_PROCESS, Boolean.TRUE);
}

@Test
public final void testRequestUrlIgnorePatternIsUsedIfPrimaryMemcachedNodeIsOperational() throws IOException, ServletException {
when(_memcachedNodesManager.isNodeAvailable(PRIMARY_NODE_IDENTIFIER)).thenReturn(true);
when(_request.getRequestURI()).thenReturn("/pixel.gif");
_sessionTrackerValve.invoke( _request, _response );

verify(_request).setNote(REQUEST_IGNORED, Boolean.TRUE);
}

protected abstract void setupGetResponseSetCookieHeadersExpectations(Response response, String[] result);

@Nonnull
Expand Down