Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add authentication context + ssr #57

Merged
merged 2 commits into from
Feb 25, 2024
Merged

add authentication context + ssr #57

merged 2 commits into from
Feb 25, 2024

Conversation

mahmoudmoravej
Copy link
Owner

We fixed important issues we had with authentication:

  • No more sessionstorage for authenticatated user. We switched to AuthenitcationContext to handle it.
  • Add server side AuthenticationContext provider to make sure auth user is loaded from scractch and also the ssr is not failing for pages access this context.
  • Logout, only redirect to a new page. So, we don't load authenticated user anymore from dashboard or any client page. It ensures we have access to user data through the whole client lifecycle.

@vercel Vercel
Copy link

vercel bot commented Feb 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
may-i-coach-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2024 9:34pm

@mahmoudmoravej mahmoudmoravej merged commit e4fed31 into main Feb 25, 2024
4 of 5 checks passed
@mahmoudmoravej mahmoudmoravej deleted the fix-sign-in-process branch February 25, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mahmoudmoravej