Mui support #68
Merged
Mui support #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is hard to say that it has been done right or not.
MUI is based on Emotions.js basically but alot of configurations are needed to setup its caching mechanism (or it was needed).
<head>. So, it is kind of advanced approach.renderToPipeableStream.server.tsx. Just added the server version ofcacheprovider** ALSO a good thread that explain alot: mui/material-ui#39765
All in all, it seems it is working for now. But we need to check it later in depth to make sure the caching work as expected. Also, do we able to move it to tailwindcss instead?