Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(typescript): migrate services/session to typescript #2873

Merged
merged 3 commits into from
Dec 26, 2024

Conversation

BobrImperator
Copy link
Collaborator

@BobrImperator BobrImperator commented Dec 23, 2024

  • Refactors services/session to typescript
  • Removes readOnly decorator in favor of native getters.

@BobrImperator BobrImperator force-pushed the typescript-refactor branch 2 times, most recently from 8fa2ba1 to 3e719a5 Compare December 26, 2024 17:57
@BobrImperator BobrImperator changed the title chore(typescript): migrate services/session chore(typescript): migrate services/session to typescript Dec 26, 2024
@BobrImperator BobrImperator marked this pull request as ready for review December 26, 2024 17:59
Copy link

github-actions bot commented Dec 26, 2024

Some tests with 'continue-on-error: true' have failed:

  • classic-test-app test:one ember-canary

  • test-app test:one ember-beta

  • classic-test-app test:one ember-beta

  • test-app test:one ember-canary

    Created by continue-on-error-comment

@BobrImperator BobrImperator merged commit 290fb30 into master Dec 26, 2024
40 of 42 checks passed
@BobrImperator BobrImperator deleted the typescript-refactor branch December 26, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant