Typescript test app #2888
Merged
Typescript test app #2888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobrImperator
changed the base branch from
master
to
implement-our-event-target
BobrImperator
force-pushed
the
typescript-test-app
branch
4 times, most recently
from
cde9f8b to
0226b3a
Compare
BobrImperator
force-pushed
the
typescript-test-app
branch
20 times, most recently
from
0326206 to
769eda3
Compare
BobrImperator
force-pushed
the
typescript-test-app
branch
from
ab7ce74 to
c587784
Compare
|
Some tests with 'continue-on-error: true' have failed:
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-appNotes:
Converting
session-stores/application.js->session-stores/application.tscauses compilation inconsistency.From build to build it'll spontaneously misbehave...
TODO
We might drop auto-injection here and tell users to declare these modules manually.