Add public accessor and Clean up

maiyaporn · Jun 18, 2017 · 09f5d36 · 09f5d36
1 parent 7b9e17a
commit 09f5d36
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 16 deletions.
diff --git a/src/wizard-step.component.ts b/src/wizard-step.component.ts
@@ -1,4 +1,4 @@
-import { Component, OnInit, Input, Output, EventEmitter } from '@angular/core';
+import { Component, Input, Output, EventEmitter } from '@angular/core';
 
 @Component({
   selector: 'wizard-step',
@@ -9,7 +9,7 @@ import { Component, OnInit, Input, Output, EventEmitter } from '@angular/core';
     </div>
   `
 })
-export class WizardStepComponent implements OnInit {
+export class WizardStepComponent {
   @Input() title: string;
   @Input() hidden: boolean = false;
   @Input() isValid: boolean = true;
@@ -25,10 +25,8 @@ export class WizardStepComponent implements OnInit {
 
   constructor() { }
 
-  ngOnInit() {
-  }
-
-  @Input('isActive') set isActive(isActive: boolean) {
+  @Input('isActive')
+  set isActive(isActive: boolean) {
     this._isActive = isActive;
     this.isDisabled = false;
   }

diff --git a/src/wizard.component.ts b/src/wizard.component.ts
@@ -1,4 +1,4 @@
-import { Component, OnInit, Output, EventEmitter, ContentChildren, QueryList, AfterContentInit } from '@angular/core';
+import { Component, Output, EventEmitter, ContentChildren, QueryList, AfterContentInit } from '@angular/core';
 import { WizardStepComponent } from './wizard-step.component';
 
 @Component({
@@ -34,7 +34,7 @@ import { WizardStepComponent } from './wizard-step.component';
     '.completed { cursor: default; }'
   ]
 })
-export class WizardComponent implements OnInit, AfterContentInit {
+export class WizardComponent implements AfterContentInit {
   @ContentChildren(WizardStepComponent)
   wizardSteps: QueryList<WizardStepComponent>;
 
@@ -46,9 +46,6 @@ export class WizardComponent implements OnInit, AfterContentInit {
 
   constructor() { }
 
-  ngOnInit() {
-  }
-
   ngAfterContentInit() {
     this.wizardSteps.forEach(step => this._steps.push(step));
     this.steps[0].isActive = true;
@@ -74,7 +71,7 @@ export class WizardComponent implements OnInit, AfterContentInit {
     }
   }
 
-  private get activeStepIndex(): number {
+  public get activeStepIndex(): number {
     return this.steps.indexOf(this.activeStep);
   }
 
@@ -86,13 +83,13 @@ export class WizardComponent implements OnInit, AfterContentInit {
     return this.activeStepIndex > 0;
   }
 
-  goToStep(step: WizardStepComponent) {
+  public goToStep(step: WizardStepComponent): void {
     if (!this.isCompleted) {
       this.activeStep = step;
     }
   }
 
-  next() {
+  public next(): void {
     if (this.hasNextStep) {
       let nextStep: WizardStepComponent = this.steps[this.activeStepIndex + 1];
       this.activeStep.onNext.emit();
@@ -101,7 +98,7 @@ export class WizardComponent implements OnInit, AfterContentInit {
     }
   }
 
-  previous() {
+  public previous(): void {
     if (this.hasPrevStep) {
       let prevStep: WizardStepComponent = this.steps[this.activeStepIndex - 1];
       this.activeStep.onPrev.emit();
@@ -110,7 +107,7 @@ export class WizardComponent implements OnInit, AfterContentInit {
     }
   }
 
-  complete() {
+  public complete(): void {
     this.activeStep.onComplete.emit();
     this._isCompleted = true;
   }