-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tompd_63wifi_breaker #2618
add tompd_63wifi_breaker #2618
Conversation
Add configuration for Tomzn TOMPD-63WIFI circuit breaker.
fix presumably wrong placement of MASK parameter
This seems very similar to existing TOMP 63 config.
My preference for this device is to modify the existing config with the two new entities you added rather than accept a new config for it. |
Seeing the conflicts in dps 104 and 105 between this and the tompd 63lw v2 config you also submitted, I'm reconsidering which should be merged with the original tompd 63lw config. Since the name matches, I think it is probably better for the other one to merge (it also only really has additional dps which can be optional), and this one to be new. I will need to clean up the main branch now to rebase this PR so it can be merge. |
Two "new" configs were submitted at the same time: TOMPD-63-WIFI, and another variant of TOMPD-63LW Initial analysis showed that the TOMPD-63-WIFI was closer to the original TOMPD-63LW config, but actually both are just extending it with a few new entities that can be made optional, and the -WIFI one actually removed some entities that the 63LW didn't. Both added numeric dps 104 and 105, but the WIFI has them as config options for Over/Under voltage handling timeouts, while the 63LW has them as sensors (power factor and frequency). Since the 63LW is the same name, it should probably get priority. PR #2619, reverting previous config merge of PR #2618
- top level name should be generic - remove names which match class, so translations are used - restore diagnostic on secondary sensors PR make-all#2618
Add configuration for Tomzn TOMPD-63WIFI circuit breaker.