-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ustellar_ut99911_rgb.yaml #2732
Conversation
Thinking about it - I'll move the entity to its own text sensor rather than it being an attribute of one of the light entities (as this has 2). Will have a play and submit another commit shortly. |
Add descriptive values for DP 103 - it denotes the RGB order for the LED strip on the back. The value can be changed, so this could be a select entity. However I don't see the point of this as it's configured in the factory for the LED strip on the device so users should never change it from the original setting. It will just mess up the colour representation on the LED strip. But it is useful to know the string value to better understand the spec of the LED strip on one of these light bars.
Correct typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the light supports white, then white should be added to colour modes. Otherwise, what is the behaviour of the light when white is selected?
If white is not supported. then color_mode is not really necessary, as it is always hs, but in that case renaming to effect keeps it within the light, and "color" in that case should map to "off" (for no effect selected), and if "white" basically does nothing, then map that to "off" as well and mark it hidden as there is no reason to select it from HA, it is just there because of a bug when controlled by the app.
DP 21 doesn't look to relates with HA's Out of curiosity, I observed the following: Changing this to Light behaviour does not change. Changing this to No change to the light.
You can change the sliders and select one of the modes in the blue circle at the top. The modes correspond to the Modes select entity in HA so if you change that, this also changes to
You can select one of the scenes at the bottom (Party etc). Sliders are greyed out/not selectable. The scenes correspond to the Scene select entity in HA so if you change that, this DP also changes to |
Maybe it is best then to rename the attribute to |
Yeah - have added it back as an attribute with the name The attribute is changing value as expected when I adjust other DPs. Thank you for the guidance! |
- don't bother to map values for app_mode, as the original values are enough to identify the meaning, and the attribute is not important enough to add the extra complexity. - revert dp 103 type to string, it seems the review comment was misinterpreted. PR make-all#2732
👍😊 |
Change incorrectly named ID for DP 21
color_mode
ID towork_mode
. This stops the following log entry:DP 21 is a string that changes when you select a different tab in the Smart Life app for the light. With this change it now shows as an attribute properly (screenshot below) and updates when I page through the different tabs in the app: