Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Hornbill Y4 Smart Lock family #3017

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jayPare
Copy link

@jayPare jayPare commented Feb 27, 2025

@jayPare
Copy link
Author

jayPare commented Feb 27, 2025

This was based on #1830 and #2824, but I still need to understand some parts. Maybe @rudironsonijr and @josefelixh can chip in?

@jayPare jayPare force-pushed the usr-jpare-hornbill branch 2 times, most recently from df236f3 to af4c381 Compare February 27, 2025 15:22
@jayPare jayPare marked this pull request as ready for review February 27, 2025 15:23
@jayPare jayPare requested a review from make-all March 1, 2025 20:37
@jayPare jayPare changed the title Adding support for Hornbill Smart Lock Adding support for Hornbill Y4 Smart Lock family Mar 1, 2025
@jayPare
Copy link
Author

jayPare commented Mar 2, 2025

@make-all I'm trying to run test_device_config.py locally but I always get this:
ModuleNotFoundError: No module named 'custom_components.tuya_local'

I'm in a venv and installed all the modules using requirements-dev.txt. I also tried to add custom_components/ and custom_components/tuya_local/ in PYTHONPATH without any success.

What am I missing?

@make-all
Copy link
Owner

make-all commented Mar 2, 2025

I don't need to add anything to my PYTHONPATH to run pytest. To run the utils with python, I need to add . to PYTHONPATH though.

@jayPare
Copy link
Author

jayPare commented Mar 2, 2025

I don't need to add anything to my PYTHONPATH to run pytest. To run the utils with python, I need to add . to PYTHONPATH though.

So you simply run python3 tests/test_device_config.py?

@jayPare
Copy link
Author

jayPare commented Mar 2, 2025

I don't need to add anything to my PYTHONPATH to run pytest. To run the utils with python, I need to add . to PYTHONPATH though.

Adding . seems to get me further, but now I get:

Traceback (most recent call last):
  File "/home/jpare/git/tuya-local/tests/test_device_config.py", line 22, in <module>
    from .const import GPPH_HEATER_PAYLOAD, KOGAN_HEATER_PAYLOAD
ImportError: attempted relative import with no known parent package

@jayPare
Copy link
Author

jayPare commented Mar 3, 2025

I don't need to add anything to my PYTHONPATH to run pytest. To run the utils with python, I need to add . to PYTHONPATH though.

My bad, I need to use pytest tests/test_device_config.py. Still a couple of TODO in hornbill_y4_smart_lock.yaml I need help with.

@jayPare jayPare force-pushed the usr-jpare-hornbill branch 2 times, most recently from 3a71dfe to f5071ec Compare March 4, 2025 03:04
@jayPare jayPare changed the title Adding support for Hornbill Y4 Smart Lock family Add support for Hornbill Y4 Smart Lock family Mar 4, 2025
@jayPare jayPare force-pushed the usr-jpare-hornbill branch 4 times, most recently from 92f2bf9 to 86ff9fe Compare March 6, 2025 12:24
@jayPare jayPare force-pushed the usr-jpare-hornbill branch from 86ff9fe to 2f501a6 Compare March 9, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

2 participants