Added authorization header to RpcClient #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 28, 2023 16:45
Signed-off-by: Roman Bylbas <[email protected]>
Signed-off-by: Roman Bylbas <[email protected]>
RomanovSci
force-pushed
the
authorization-header
branch
from
99af6a7 to
d65a0cc
Compare
Signed-off-by: Roman Bylbas <[email protected]>
ihor
reviewed
Nov 29, 2023
src/Rpc/RpcClient.php
Outdated
| private ?string $lastApiVersion = null; | ||
|
|
||
| public function __construct(string $nodeUrl) | ||
| public function __construct(string $nodeUrl, string $bearerToken = null) |
There was a problem hiding this comment.
Let's make it accept additional headers instead of the specific one. I'm not sure if we accept it as Authorization: Bearer <token>, and not as Authorization: <token>
added 2 commits
November 29, 2023 11:49
Signed-off-by: Roman Bylbas <[email protected]>
Signed-off-by: Roman Bylbas <[email protected]>
ihor
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.