Return not prefixed signature from sdk event response

make-software · Dec 9, 2024 · c3a9479 · c3a9479
1 parent cdc5091
commit c3a9479
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/src/libs/services/deployer-service/index.ts b/src/libs/services/deployer-service/index.ts
@@ -239,7 +239,7 @@ export const signLedgerDeploy = async (
 
   const approval = new DeployUtil.Approval();
   approval.signer = activeAccount.publicKey;
-  approval.signature = resp.signatureHex;
+  approval.signature = resp.prefixedSignatureHex;
   deploy.approvals.push(approval);
 
   return deploy;

diff --git a/src/libs/services/ledger/ledger.ts b/src/libs/services/ledger/ledger.ts
@@ -302,18 +302,18 @@ export class Ledger {
           ? result.signatureRSV.subarray(0, 64)
           : result.signatureRSV;
 
-      const signatureHex = `02${patchedSignature.toString('hex')}`;
+      const prefixedSignatureHex = `02${patchedSignature.toString('hex')}`;
 
       this.#LedgerEventStatussSubject.next({
         status: LedgerEventStatus.SignatureCompleted,
         publicKey: account.publicKey,
         deployHash,
-        signatureHex
+        signatureHex: prefixedSignatureHex
       });
 
       const prefix = new Uint8Array([0x02]);
 
-      if (!signatureHex) {
+      if (!prefixedSignatureHex) {
         this.#processError({
           status: LedgerEventStatus.SignatureFailed,
           publicKey: account.publicKey,
@@ -323,8 +323,10 @@ export class Ledger {
       }
 
       return {
-        signatureHex,
-        signature: new Uint8Array([...prefix, ...patchedSignature])
+        signatureHex: patchedSignature.toString('hex'),
+        signature: patchedSignature,
+        prefixedSignatureHex,
+        prefixedSignature: new Uint8Array([...prefix, ...patchedSignature])
       };
     } catch (e) {
       if (e instanceof LedgerError) {
@@ -342,7 +344,7 @@ export class Ledger {
   async signMessage(
     message: string,
     account: Partial<LedgerAccount>
-  ): Promise<SignResult> {
+  ): Promise<Pick<SignResult, 'signature' | 'signatureHex'>> {
     try {
       if (account.index === undefined) {
         this.#processError({ status: LedgerEventStatus.InvalidIndex });

diff --git a/src/libs/services/ledger/types.ts b/src/libs/services/ledger/types.ts
@@ -49,6 +49,8 @@ export interface LedgerAccountsOptions {
 export interface SignResult {
   signatureHex: string;
   signature: Uint8Array;
+  prefixedSignatureHex: string;
+  prefixedSignature: Uint8Array;
 }
 
 export type LedgerTransport = 'USB' | 'Bluetooth';