Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: inactive users index #427

Conversation

pajgo
Copy link
Collaborator

@pajgo pajgo commented Sep 20, 2019

Sub task for inactive users delete

@codecov
Copy link

codecov bot commented Sep 20, 2019

Codecov Report

❗ No coverage uploaded for pull request base (pajgo-feat/delete-inactive-users@25186e7). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@                         Coverage Diff                         @@
##             pajgo-feat/delete-inactive-users     #427   +/-   ##
===================================================================
  Coverage                                    ?   94.63%           
===================================================================
  Files                                       ?      131           
  Lines                                       ?     2404           
  Branches                                    ?        0           
===================================================================
  Hits                                        ?     2275           
  Misses                                      ?      129           
  Partials                                    ?        0
Impacted Files Coverage Δ
src/constants.js 100% <ø> (ø)
src/actions/remove.js 96% <100%> (ø)
src/actions/register.js 96.37% <100%> (ø)
src/utils/inactiveUsers/index.js 100% <100%> (ø)
src/actions/activate.js 85.24% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25186e7...9612990. Read the comment docs.

src/actions/register.js Outdated Show resolved Hide resolved
@AVVS
Copy link
Member

AVVS commented Sep 26, 2019

this lacks a method that will clean up inactive index of user ids that had expired and never completed activation - needs to be added before the PR can be merged

@pajgo
Copy link
Collaborator Author

pajgo commented Sep 26, 2019

this lacks a method that will clean up inactive index of user ids that had expired and never completed activation - needs to be added before the PR can be merged

Clean up method planned in Parent PR which contains delete user procedure. It's a transitional PR. Maybe It should be removed and code migrated into parent PR?

Added temporary cleanup logic.

@pajgo pajgo changed the title feat: inactive users index [WIP] feat: inactive users index Sep 26, 2019
@pajgo pajgo requested a review from AVVS September 26, 2019 13:33
@pajgo pajgo changed the base branch from master to pajgo-feat/delete-inactive-users September 27, 2019 12:29
@pajgo pajgo force-pushed the feat/delinactive/inactiveUserIndex branch from 638e622 to 9612990 Compare October 21, 2019 14:46
@pajgo pajgo force-pushed the pajgo-feat/delete-inactive-users branch from 25186e7 to d9f0aad Compare October 21, 2019 15:02
@pajgo
Copy link
Collaborator Author

pajgo commented Oct 22, 2019

Closing this PR changes merged into #430

@pajgo pajgo closed this Oct 22, 2019
@pajgo pajgo deleted the feat/delinactive/inactiveUserIndex branch October 22, 2019 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants