feat: update user and organization metadata #431
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AVVS
commented
Oct 30, 2019
src/utils/metadata/user.js
Outdated
|
|
||
| const { USERS_METADATA, USERS_AUDIENCE } = require('../../constants'); | ||
|
|
||
| class User { |
There was a problem hiding this comment.
Suggested change
| class User { | |
| class UserMetadata { |
AVVS
commented
Oct 30, 2019
| return redis[name](keys.length, keys, argv); | ||
| }); | ||
|
|
||
| return Promise.all(scripts).then((res) => UpdateMetadata.mapScriptResponse($scriptKeys, res)); |
There was a problem hiding this comment.
Suggested change
| return Promise.all(scripts).then((res) => UpdateMetadata.mapScriptResponse($scriptKeys, res)); | |
| const res = await Promise.all(scripts); | |
| return UpdateMetadata.mapScriptResponse($scriptKeys, res); |
AVVS
commented
Oct 30, 2019
| const operations = metaOps.map((meta, idx) => UpdateMetadata.handleAudience(pipe, keys[idx], meta)); | ||
| return pipe.exec() | ||
| .then(handlePipeline) | ||
| .then((res) => UpdateMetadata.mapMetaResponse(operations, res)); |
There was a problem hiding this comment.
тут тоже
const res = handlePipeline(await pipe.exec());
return UpdateMetadata.mapMetaResponse(operations, res);
AVVS
commented
Oct 30, 2019
| */ | ||
| async batchUpdate(opts) { | ||
| const { redis } = this; | ||
| assert(!(redis instanceof Pipeline), 'impossible to use with pipeline'); |
There was a problem hiding this comment.
Suggested change
| assert(!(redis instanceof Pipeline), 'impossible to use with pipeline'); | |
| assert(!(redis instanceof Pipeline), 'impossible to use without pipeline'); |
AVVS
commented
Oct 30, 2019
src/utils/metadata/redis/audience.js
Outdated
| audienceWork.push( | ||
| redis.sadd(this.getAudienceKey(id), audience) | ||
| ); | ||
| } |
There was a problem hiding this comment.
sadd принимает массив значений, можно упростить:
redis.sadd(this.getAudienceKey(id), audiences)потому что:
// Arguments to commands are flattened, so the following are the same:
redis.sadd("set", 1, 3, 5, 7);
redis.sadd("set", [1, 3, 5, 7]);
There was a problem hiding this comment.
по сути весь метод .batchAdd не нужен тк он равнозначен .add
AVVS
commented
Oct 30, 2019
src/utils/metadata/user.js
Outdated
| * @param audience | ||
| * @returns {Promise<void>} | ||
| */ | ||
| update(id, hashKey, value, audience) { |
There was a problem hiding this comment.
я бы добавил проверку наличия всех аргументов, иначе может программист допустить ошибку и забыть добавить какой-то аргумент
assert там использовать или что-то в этом роде
pajgo
force-pushed
the
feat/delinactive/update-metadata-rework
branch
from
a8bc8e0 to
0b092f6
Compare
* asserts and rf update
AVVS
commented
Nov 1, 2019
| const metaOps = Array.isArray(metadata) ? metadata : [metadata]; | ||
|
|
||
| if (metaOps.length !== audiences.length) { | ||
| return Promise.reject(new HttpStatusError(400, 'audiences must match metadata entries')); |
There was a problem hiding this comment.
Suggested change
| return Promise.reject(new HttpStatusError(400, 'audiences must match metadata entries')); | |
| throw new HttpStatusError(400, 'audiences must match metadata entries'); |
* slight api changes
* UserMetadata for->using
* delete all metadata on remove
|
#436 Dup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.