-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: platform ux improvement #6555
chore: platform ux improvement #6555
Conversation
WalkthroughThis pull request updates translation keys across multiple locale JSON files by removing redundant possessive prefixes. In the English and Chinese files, the keys Changes
Sequence Diagram(s)sequenceDiagram
participant IB as IssueBlock
participant Tooltip as Tooltip
participant IS as IssueStats
participant IP as IssueProperties
IB->>Tooltip: Render issue name tooltip
alt Issue is Epic
IB->>IS: Render IssueStats
end
IB->>IP: Render IssueProperties
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Tip 🌐 Web search-backed reviews and chat
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
web/core/components/issues/issue-layouts/list/block.tsx (1)
149-150
: Track the TODO for improving ID/Key width logic.The current width calculation (
projectIdentifier?.length ?? 0) * 7
) is a basic approximation. This should be tracked for improvement to ensure consistent and accurate width calculations.Would you like me to create an issue to track this TODO for improving the ID/Key width logic?
packages/i18n/src/locales/ja/translations.json (1)
170-171
: Consistent Key Renaming & Removal.
The translation key"your_favorites"
has been replaced with"favorites"
and the key"your_projects"
has been removed. Please ensure that all UI components referencing favorites or projects are updated accordingly to reflect this change and maintain consistency across all locale files.packages/i18n/src/locales/es/translations.json (1)
170-171
: Streamlined Translation Keys.
The key"your_favorites"
is now updated to"favorites"
with the value"Favoritos"
, and the obsolete key"your_projects"
has been removed. Verify that these changes are properly integrated in the application UI to avoid any missing translations.packages/i18n/src/locales/fr/translations.json (1)
170-171
: Updated Localization Keys for Clarity.
The revision replaces"your_favorites"
with"favorites"
(now set to"Favoris"
) and removes"your_projects"
, in line with the changes made in other locales. Double-check that the front-end components use these updated keys to ensure a uniform user experience across the application.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
packages/i18n/src/locales/en/translations.json
(1 hunks)packages/i18n/src/locales/es/translations.json
(1 hunks)packages/i18n/src/locales/fr/translations.json
(1 hunks)packages/i18n/src/locales/ja/translations.json
(1 hunks)packages/i18n/src/locales/zh-CN/translations.json
(1 hunks)web/core/components/issues/issue-layouts/list/block.tsx
(1 hunks)web/core/components/workspace/sidebar/favorites/favorites-menu.tsx
(1 hunks)web/core/components/workspace/sidebar/projects-list.tsx
(1 hunks)web/core/components/workspace/sidebar/workspace-menu-header.tsx
(1 hunks)
✅ Files skipped from review due to trivial changes (5)
- web/core/components/workspace/sidebar/favorites/favorites-menu.tsx
- web/core/components/workspace/sidebar/workspace-menu-header.tsx
- web/core/components/workspace/sidebar/projects-list.tsx
- packages/i18n/src/locales/en/translations.json
- packages/i18n/src/locales/zh-CN/translations.json
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Analyze (javascript)
- GitHub Check: Analyze (python)
🔇 Additional comments (1)
web/core/components/issues/issue-layouts/list/block.tsx (1)
262-262
: LGTM! IssueStats placement improved.The new placement of
IssueStats
after the issue name provides a more natural flow in the UI layout, improving the visual hierarchy and readability.
Description
This PR includes following changes:
Type of Change
References
[WEB-3319]
Summary by CodeRabbit