Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmooney-20210430: Add note about skim()/thaw() #230

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cmooney-20210430: Add note about skim()/thaw() #230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/end.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,11 @@ interface SpotLike {
all auctions are in the reverse (`dent`) phase. There are two ways
of ensuring this:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line references two options on old line 151 and 158. The new comment seems to be wedged in the middle

Copy link
Contributor

@gbalabasquer gbalabasquer May 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'd suggest moving the new paragraph right after - backing collateral taken


NOTE: In the event there's a system surplus, and there are no
under-collateralised vaults remaining, one must skim() large CDPs in order
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it only large CDPs? Seems like if we need 0 surplus we need to skim all non-empty CDPs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need to skim() everything, as we just need enough to collect fees get surplus to 0. The surplus cap means some of those fees are owed, but were sent off to surplus auctions. That is, surplus < all fees owed.

to account for the fees built up in the surplus buffer. Without doing this
the thaw() will fail to complete as it requires the surplus buffer be empty.

4a. i) `wait`: set the cooldown period to be at least as long as the
longest auction duration, which needs to be determined by the
cage administrator.
Expand Down