-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull request - Stephanie #226
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything looks good, solid start, looks like good foundations to finish the challenge :)
erb :post | ||
end | ||
|
||
post '/postpeep' do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This route might be clearer and stick to conventions better if it were called '/peep/new'
end | ||
|
||
def self.all | ||
if ENV['ENVIRONMENT'] == 'test' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you not use the db setup helper here to remove this if else statement?
This is a really nice solution but it appears you have added user specific functionality before implementing the functionality from the user stories? You should always prioritise the functionality described in user stories that the business requires over nice to haves. It would also be really nice to see the README updated to include functionality finished and running instructions. I have left a couple inline comments where there are small things that could be improved. If you have any questions about any of this please let me know and we can chat! |
Your name
Please write your full name here to make it easier to find your pull request.
User stories
Please list which user stories you've implemented (delete the ones that don't apply).
README checklist
Does your README contains instructions for
Here is a pill that can help you write a great README!