clang-tidy: fixes errors in Lua filter (envoyproxy#37543)

part of envoyproxy#28566 Signed-off-by: Takeshi Yoneda <[email protected]>
makesoftwaresafe · Dec 9, 2024 · 0ff8fc3 · 0ff8fc3
1 parent 33c9494
commit 0ff8fc3
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/source/extensions/filters/common/lua/lua.h b/source/extensions/filters/common/lua/lua.h
@@ -171,6 +171,8 @@ template <class T> class BaseLuaObject : public LuaLoggable {
     };
 
     std::vector<luaL_Reg> to_register;
+    // Reserve slots to avoid reallocation, otherwise clang-tidy will complain about it.
+    to_register.reserve(log_functions.size() + T::exportedFunctions().size() + 2);
 
     for (auto& function : log_functions) {
       to_register.push_back({function.first, function.second});
@@ -331,7 +333,7 @@ template <typename T> class LuaRef {
 
   LuaRef(const LuaRef&) = delete;
 
-  LuaRef(LuaRef&& that) {
+  LuaRef(LuaRef&& that) noexcept {
     object_ = that.object_;
     ref_ = that.ref_;
     that.object_ = std::pair<T*, lua_State*>{};
@@ -394,7 +396,7 @@ template <typename T> class LuaDeathRef : public LuaRef<T> {
   using LuaRef<T>::LuaRef;
 
   LuaDeathRef(const LuaDeathRef&) = delete;
-  LuaDeathRef(LuaDeathRef&&) = default;
+  LuaDeathRef(LuaDeathRef&&) noexcept = default;
 
   ~LuaDeathRef() { markDead(); }