[pull] master from grpc:master #576
Open
+420
−413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Move callback from `std::function` --> `absl::AnyInvocable` to enable move-only callbacks, and remove the requirement to pass a `DebugLocation` - since we can synthesize this with a default argument - which cleans up a lot of visual noise across the codebase. Closes #38647 COPYBARA_INTEGRATE_REVIEW=#38647 from ctiller:great-work 36ecdde PiperOrigin-RevId: 721507275
It's deprecated. Bug: https://crbug.com/388068052 Closes #38542 COPYBARA_INTEGRATE_REVIEW=#38542 from victorvianna:master 00b52c6 PiperOrigin-RevId: 721538753
Fix missing windows symbol linker errors found when adding gRPC to BCR (From bazelbuild/bazel-central-registry#3671). ``` C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.39.33519\bin\HostX64\x64\link.exe @bazel-out/x64_windows-fastbuild/bin/external/grpc+/third_party/address_sorting/address_sorting_6658ee4b.dll-0.params # Configuration: 5b453b61a931a5d60d186b4b1192045ad0e097a738f75edb2ec811e836145bd1 # Execution platform: @@platforms//host:host Creating library bazel-out/x64_windows-fastbuild/bin/external/grpc+/third_party/address_sorting/address_sorting.if.lib and object bazel-out/x64_windows-fastbuild/bin/external/grpc+/third_party/address_sorting/address_sorting.if.exp address_sorting.obj : error LNK2019: unresolved external symbol __imp_htonl referenced in function in6_is_addr_loopback address_sorting_windows.obj : error LNK2019: unresolved external symbol __imp_closesocket referenced in function address_sorting_create_source_addr_factory_for_current_platform address_sorting_windows.obj : error LNK2019: unresolved external symbol __imp_connect referenced in function address_sorting_create_source_addr_factory_for_current_platform address_sorting_windows.obj : error LNK2019: unresolved external symbol __imp_getsockname referenced in function address_sorting_create_source_addr_factory_for_current_platform address_sorting_windows.obj : error LNK2019: unresolved external symbol __imp_socket referenced in function address_sorting_create_source_addr_factory_for_current_platform bazel-out\x64_windows-fastbuild\bin\external\grpc+\third_party\address_sorting\address_sorting_6658ee4b.dll : fatal error LNK1120: 5 unresolved externals ``` This issue wasn't caught by out CI, likely due to BCR presubmit's use of stricter layering_check. Regardless, it's good as it correctly defines the `address_sorting` Bazel target's dependency. Closes #38648 PiperOrigin-RevId: 721549737
Values carrying grpc_http2_error_code ought to be able to carry the full range of expressible error codes - but could not because we did not specify the backing type. Do so, and add a regression test that caught this. PiperOrigin-RevId: 721604484
…nce documentation (#38616) `requirements.bazel.txt` should only be used for Bazel tests, thus creating another file to generated API reference documentation <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes #38616 COPYBARA_INTEGRATE_REVIEW=#38616 from XuanWang-Amos:create_dep_file b1eb128 PiperOrigin-RevId: 721665087
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )