Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cart upgrades #448

Merged
merged 6 commits into from
Jan 30, 2025
Merged

Cart upgrades #448

merged 6 commits into from
Jan 30, 2025

Conversation

apledger
Copy link
Contributor

@apledger apledger commented Jan 2, 2025

  • Refactored Cart to use Streamable pattern
  • Polished skeletons to perfectly match all breakpoints
  • Refactored Summary props to allow for arbitrary line items

Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vibes ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 7:35pm

migueloller
migueloller previously approved these changes Jan 3, 2025
Copy link
Member

@migueloller migueloller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me 👍🏻

Just had a couple of comments

apps/web/vibes/soul/sections/cart/index.tsx Outdated Show resolved Hide resolved
apps/web/vibes/soul/sections/cart/index.tsx Outdated Show resolved Hide resolved
apps/web/vibes/soul/sections/cart/index.tsx Outdated Show resolved Hide resolved
apps/web/vibes/soul/sections/cart/index.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@hunterbecton hunterbecton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@migueloller migueloller merged commit 2924a53 into main Jan 30, 2025
4 checks passed
@migueloller migueloller deleted the ap/cart branch January 30, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants