No issue - Mainly fixes in documentation #207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pounard
reviewed
Nov 28, 2024
| # If you have more than one connection, it is strongly advised to configure | ||
| # this for each connection instead. | ||
| #backup_excluded_tables: ['table1', 'table2'] | ||
|
|
||
| # Specify here paths to backup and restore binaries and command line options. | ||
| # Specify here paths to back up and restore binaries and command line options. |
There was a problem hiding this comment.
You should probably keep "backup" here.
pounard
reviewed
Nov 28, 2024
| @@ -54,7 +54,7 @@ | |||
| # Connection name will be "default" when configured this way. | |||
| connections: "pgsql://username:password@hostname:port?version=16.0&other_option=..." | |||
|
|
|||
| # Alternatively, you are allowed to have more than one connections, case | |||
| # Alternatively, you are allowed to have more than one connection, case | |||
There was a problem hiding this comment.
"More" than one, shouldn't be plural "connections" here ?
There was a problem hiding this comment.
Or that may be a frenchism, I'm not sure about english grammar here.
pounard
reviewed
Nov 28, 2024
| # If you have more than one connection, it is strongly advised to configure | ||
| # this for each connection instead. | ||
| #backup_excluded_tables: ['table1', 'table2'] | ||
|
|
||
| # Specify here paths to backup and restore binaries and command line options. | ||
| # Specify here paths to back up and restore binaries and command line options. |
There was a problem hiding this comment.
Same as upper, I would keep "backup" as a single word?
pounard
reviewed
Nov 28, 2024
| @@ -36,7 +36,7 @@ You can specify the behavior of the command with some options detailed below. | |||
|
|
|||
| <div class="standalone"> | |||
|
|
|||
| By default, the command will backup the database from the default connection. | |||
| By default, the command will back up the database from the default connection. | |||
pounard
reviewed
Nov 28, 2024
| @@ -48,7 +48,7 @@ vendor/bin/db-tools backup --connection other_connection_name | |||
| </div> | |||
| <div class="symfony"> | |||
|
|
|||
| By default, the command will backup the database from the default DBAL connection. | |||
| By default, the command will back up the database from the default DBAL connection. | |||
pounard
reviewed
Nov 28, 2024
| @@ -62,21 +62,20 @@ class within, then register those as anonymizers. | |||
| ```yaml | |||
| db_tools: | |||
| anonymizer_paths: | |||
| - '%kernel.project_dir%/vendor/makinacorpus/db-tools-bundle/src/Anonymizer' | |||
| - '%kernel.project_dir%/src/Anonymization/Anonymizer' | |||
| - '%kernel.project_dir%/vendor/makinacorpus/db-tools-bundle/src/Anonymization/Anonymizer/Core' | |||
There was a problem hiding this comment.
Actually, that's not true anymore, anonymizers are registered using an array constant which contains the class names, it is not using a path lookup anymore.
pounard
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a doubt about the precision of the
Coredirectory when loading default anonymizers or mentioning them in documentation. If it is not a good idea, I let you remove it 😉