Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hard Delete Action to SafeDeleteAdmin #236

Merged
merged 3 commits into from
Aug 30, 2023

Conversation

Xalph555
Copy link
Contributor

Adding a hard delete action to allow admins to permanently delete soft deleted records.

Function itself is near identical to the undelete_selected action but I am unsure whether we want to create another function, or functions, to extract the common behaviours.

@Gagaro
Copy link
Member

Gagaro commented Aug 21, 2023

Thanks for the PR 👍 .

Could you check and fix the flake8 errors.

With only two functions, this should be all right to duplicate the logic there.

@Xalph555
Copy link
Contributor Author

Fixed the Flake8 errors

@Gagaro
Copy link
Member

Gagaro commented Aug 28, 2023

Thanks, there's still one left: safedelete/admin.py:82:1: W293 blank line contains whitespace

@Xalph555
Copy link
Contributor Author

Sorry about that. Hopefully I got them all now.

@Xalph555
Copy link
Contributor Author

Added commit in attempt to fix the latest workflow errors

@coveralls
Copy link

Coverage Status

coverage: 96.779% (-0.09%) from 96.873% when pulling 52a7867 on Xalph555:Hard-Delete-Admin-Action into 6cdd3e8 on makinacorpus:master.

@Gagaro
Copy link
Member

Gagaro commented Aug 30, 2023

Thanks again for the PR and the follow ups 👌 .

@Gagaro Gagaro merged commit a0fa764 into makinacorpus:master Aug 30, 2023
14 checks passed
@jvdminne
Copy link

jvdminne commented Nov 3, 2023

I see that in the CHANGES file this one is mentioned for release 1.3.3, but as stated is not available as pip package yet. Is there any ETA on when this feature will be released? This is a feature that we would really like to implement in some of our projects.

@Gagaro
Copy link
Member

Gagaro commented Nov 13, 2023

Hi @jvdminne , I just released 1.3.3, enjoy 😃 .

@jvdminne
Copy link

Awesome, thanks! I will try it asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants