Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 Remove usage of internal sklearn.utils api, replace with equivalent #214

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

RozeQz
Copy link

@RozeQz RozeQz commented Oct 25, 2024


name: "Pull request"
about: Make changes in scikit-uplift

📑 Description of the Change

I was trying to use this library with the modern version of sklearn in which they moved function check_matplotlib_support to the _optional_dependencies folder which looks like an internal one and thus can be moved again later. To properly solve this, I copied the implementation of this function to our utils.

Verification Process

I tested a new version of library in my project and also checked it in existing tests.

Release Notes

  • Remove usage of internal sklearn.utils.check_matplotlib_support api and replace with equivalent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant