False positives negatives rate #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasanari
reviewed
Oct 9, 2024
malsim/sims/mal_simulator.py
Outdated
| @@ -654,9 +655,15 @@ def _observe_defender( | |||
| observation["observed_state"][index] = 1 | |||
| else: | |||
| if node.is_compromised(): | |||
| observation["observed_state"][index] = 1 | |||
| fn_rate = node.extras.get('false_negative_rate') | |||
| make_false_negative = fn_rate and random() < fn_rate | |||
There was a problem hiding this comment.
I would advise using a random number generator object here, so that the simulator respects the given seed.
There was a problem hiding this comment.
Make sense, will fix that.
There was a problem hiding this comment.
I made a lot of changes to the PR after restructuring was done in the main branch. Needs to be reviewed again.
There was a problem hiding this comment.
I also added a test for the rng functionality to make sure a seed makes it deterministic.
mrkickling
force-pushed
the
false-positives-negatives-rate
branch
2 times, most recently
from
7053d6d to
cd0e80a
Compare
mrkickling
force-pushed
the
false-positives-negatives-rate
branch
from
9f5e512 to
f4e9fba
Compare
kasanari
reviewed
Oct 18, 2024
kasanari
approved these changes
Oct 18, 2024
- Make it possible to set fp/fn rates in a scenario config file - Add rate to nodes .extras field
…pport for false positives
mrkickling
force-pushed
the
false-positives-negatives-rate
branch
from
486e523 to
12c2cda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current state:
The are applied by scenario on the attack graph into node.extras field and used when creating the observation.