Preamble mem leak was fixed #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nekto89
reviewed
Oct 5, 2023
| @@ -63,7 +63,6 @@ class GDCM_EXPORT Preamble | |||
| } | |||
| Preamble& operator=(Preamble const &) | |||
| { | |||
| Internal = nullptr; | |||
| Create(); | |||
| return *this; | |||
There was a problem hiding this comment.
shouldn't we also copy characters from Internal?
There was a problem hiding this comment.
To follow the current logic, we should not. Both copy operator and copy assign operator do not actually copy any data but fill allocated memory in some curtain fixed way. Moreover, these operators do not have an explicit input object.
Thus, let's wait for author's response.
Anyway, it not a big deal to add true copying, if it will be needed.
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preamble's assign operator does not delete allocated memory before assigning nullptr to pointer. After the fix an allocated memory is reused.