Reduce number of warnings

Source/DataStructureAndEncodingDefinition/gdcmByteValue.h

@@ -22,6 +22,7 @@
 #include <iterator>
 #include <iomanip>
 #include <algorithm>
+#include <cstring>
 
 namespace gdcm_ns
 {
@@ -34,14 +35,15 @@ using namespace gdcm;
 class GDCM_EXPORT ByteValue : public Value
 {
 public:
-  ByteValue(const char* array = nullptr, VL const &vl = 0):
-    Internal(array, array+vl),Length(vl) {
+  ByteValue(const char* array = nullptr, VL const &vl = 0): Length(vl) {
       if( vl.IsOdd() )
         {
         gdcmDebugMacro( "Odd length" );
-        Internal.resize(vl+1);
         ++Length;
         }
+      Internal.resize(Length);
+      if(array)
+        std::memcpy(Internal.data(), array, Length);
   }
 
   /// \warning casting to uint32_t

Source/DataStructureAndEncodingDefinition/gdcmElement.h

@@ -392,7 +392,7 @@ static void x16printf(char *buf, int size, Float f) {
       strcpy(buf, mant);
       return;
     }
-    strncpy(buf, mant, iexp + 1);
+    memcpy(buf, mant, iexp + 1);
     buf[iexp + 1] = '.';
     strncpy(buf + iexp + 2, mant + iexp + 1, size - iexp - 1);
     buf[size] = 0;
@@ -409,7 +409,7 @@ static void x16printf(char *buf, int size, Float f) {
     for(j=0; j< -1 - iexp; j++) {
       buf[j+1] = '0';
     }
-    strncpy(buf - iexp, mant, size + 1 + iexp);
+    memcpy(buf - iexp, mant, size + 1 + iexp);
     buf[size] = 0;
     clean(buf);
   }
@@ -607,7 +607,7 @@ class Element<TVR, VM::VM1_n>
         Save = true; // ????
         if( Internal )
           {
-          memcpy(internal, Internal, len);
+          memcpy((void*)internal, (void*)Internal, Length);
           delete[] Internal;
           }
         Internal = internal;
@@ -622,7 +622,7 @@ class Element<TVR, VM::VM1_n>
     bool save = false) {
     if( save ) {
       SetLength(len); // realloc
-      memcpy(Internal, array, len/*/sizeof(Type)*/);
+      memcpy((void*)Internal, (void*)array, len/*/sizeof(Type)*/);
       assert( Save == false );
       }
     else {

Source/MediaStorageAndFileFormat/gdcmDataSetHelper.cxx

@@ -213,7 +213,7 @@ VR DataSetHelper::ComputeVR(File const &file, DataSet const &ds, const Tag& tag)
       {
       // For Pixel Data:
       // if( !ds.FindDataElement( bitsallocated ) ) return VR::UN;
-      Attribute<0x0028,0x0100> at;
+      // Attribute<0x0028,0x0100> at;
       // at.SetFromDataElement( ds.GetDataElement( bitsallocated ) );
       }
     (void)v;

Testing/Source/DataStructureAndEncodingDefinition/Cxx/TestElement1.cxx

@@ -114,7 +114,7 @@ int TestAT()
   list[0] = Tag(0x0010,0x0010);
   list[1] = Tag(0x0010,0x0020);
   list[2] = Tag(0x0020,0x0013);
-  memcpy(&a, list, sizeof(list));
+  memcpy((void*)&a, (void*)list, sizeof(list));
   a.Print( std::cout );
   std::cout << std::endl;
 

Utilities/gdcmcharls/jpegmarkersegment.cpp

@@ -58,7 +58,7 @@ unique_ptr<JpegMarkerSegment> JpegMarkerSegment::CreateJpegFileInterchangeFormat
     content.push_back(static_cast<uint8_t>(params.Ythumbnail));
     if (params.Xthumbnail > 0)
     {
-        if (params.thumbnail)
+        if (!params.thumbnail)
             throw CreateSystemError(ApiResult::InvalidJlsParameters, "params.Xthumbnail is > 0 but params.thumbnail == null_ptr");
 
         content.insert(content.end(), static_cast<uint8_t*>(params.thumbnail),

Utilities/gdcmrle/io.cxx

@@ -78,6 +78,7 @@ int source::read_into_segments( char * out, int len, image_info const & ii )
         int nvalues = read(out + 0 * llen, llen);
         assert( nvalues == llen ); (void)nvalues;
         bool b = seek(pos + 1 * plane);
+        (void)b;
         assert(b);
         nvalues = read(out + 1 * llen, llen);
         assert( nvalues == llen ); (void)nvalues;

Utilities/socketxx/socket++/fork.cpp

@@ -38,9 +38,12 @@ Fork::KillForks::~KillForks ()
   // First, kill all children whose kill_child flag is set.
   // Second, wait for other children to die.
 {
-  for (ForkProcess* cur = Fork::ForkProcess::list; cur; cur = cur->next)
-    if (cur->kill_child)
+
+  for (ForkProcess* cur = Fork::ForkProcess::list; cur != nullptr; cur = cur->next)
+    if (cur->kill_child) {
       delete cur;
+      break;
+    }
 
   while (Fork::ForkProcess::list && wait (nullptr) > 0) {}
 }