Skip to content

Commit

Permalink
Code check
Browse files Browse the repository at this point in the history
  • Loading branch information
Sunanda committed Sep 5, 2021
1 parent e487015 commit c81ed0a
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 10 deletions.
8 changes: 6 additions & 2 deletions SimCalorimetry/HcalSimAlgos/interface/HcalSignalGenerator.h
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,18 @@ class HcalSignalGenerator : public HcalBaseSignalGenerator {

~HcalSignalGenerator() override {}

void initializeEvent(const edm::Event* event, const edm::EventSetup* eventSetup, const edm::ESGetToken<HcalDbService, HcalDbRecord>& tok) {
void initializeEvent(const edm::Event* event,
const edm::EventSetup* eventSetup,
const edm::ESGetToken<HcalDbService, HcalDbRecord>& tok) {
theEvent = event;
theConditions = &(eventSetup->getData(tok));
theParameterMap->setDbService(theConditions);
}

/// some users use EventPrincipals, not Events. We support both
void initializeEvent(const edm::EventPrincipal* eventPrincipal, const edm::EventSetup* eventSetup, const edm::ESGetToken<HcalDbService, HcalDbRecord>& tok) {
void initializeEvent(const edm::EventPrincipal* eventPrincipal,
const edm::EventSetup* eventSetup,
const edm::ESGetToken<HcalDbService, HcalDbRecord>& tok) {
theEventPrincipal = eventPrincipal;
theConditions = &(eventSetup->getData(tok));
theParameterMap->setDbService(theConditions);
Expand Down
6 changes: 3 additions & 3 deletions SimCalorimetry/HcalSimAlgos/test/CaloSamplesAnalyzer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ class CaloSamplesAnalyzer : public edm::one::EDAnalyzer<edm::one::SharedResource
edm::EDGetTokenT<std::vector<CaloSamples>> tok_calo;
edm::ESGetToken<CaloGeometry, CaloGeometryRecord> tokGeom_;
edm::ESGetToken<HcalDDDRecConstants, HcalRecNumberingRecord> tokRecCns_;
edm::ESGetToken<HcalDbService,HcalDbRecord> tokDB_;
edm::ESGetToken<HcalDbService, HcalDbRecord> tokDB_;
};

//
Expand All @@ -111,8 +111,8 @@ CaloSamplesAnalyzer::CaloSamplesAnalyzer(const edm::ParameterSet& iConfig)
edm::InputTag(iConfig.getParameter<std::string>("hitsProducer"), "HcalHits"))),
tok_calo(consumes<std::vector<CaloSamples>>(iConfig.getParameter<edm::InputTag>("CaloSamplesTag"))),
tokGeom_(esConsumes<CaloGeometry, CaloGeometryRecord, edm::Transition::BeginRun>()),
tokRecCns_(esConsumes<HcalDDDRecConstants, HcalRecNumberingRecord, edm::Transition::BeginRun>()),
tokDB_(esConsumes<HcalDbService,HcalDbRecord>()) {
tokRecCns_(esConsumes<HcalDDDRecConstants, HcalRecNumberingRecord, edm::Transition::BeginRun>()),
tokDB_(esConsumes<HcalDbService, HcalDbRecord>()) {
usesResource("TFileService");
}

Expand Down
6 changes: 3 additions & 3 deletions SimCalorimetry/HcalSimAlgos/test/HcalDigitizerTest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@ class HcalDigitizerTest : public edm::one::EDAnalyzer<edm::one::WatchRuns> {
const HcalTimeSlew* hcalTimeSlew_delay_;
};

HcalDigitizerTest::HcalDigitizerTest(const edm::ParameterSet& iConfig) :
tok_htopo_(esConsumes<HcalTopology, HcalRecNumberingRecord>()),
tok_slew_(esConsumes<HcalTimeSlew, HcalTimeSlewRecord>(edm::ESInputTag("", "HBHE"))) {
HcalDigitizerTest::HcalDigitizerTest(const edm::ParameterSet& iConfig)
: tok_htopo_(esConsumes<HcalTopology, HcalRecNumberingRecord>()),
tok_slew_(esConsumes<HcalTimeSlew, HcalTimeSlewRecord>(edm::ESInputTag("", "HBHE"))) {
//DB helper preparation
dbHardcode.setHB(HcalHardcodeParameters(iConfig.getParameter<edm::ParameterSet>("hb")));
dbHardcode.setHE(HcalHardcodeParameters(iConfig.getParameter<edm::ParameterSet>("he")));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
using namespace std;
namespace edm {
// Constructor
DataMixingHcalDigiWorkerProd::DataMixingHcalDigiWorkerProd(const edm::ParameterSet &ps, edm::ConsumesCollector &&iC, const edm::ESGetToken<HcalDbService, HcalDbRecord>& tok)
DataMixingHcalDigiWorkerProd::DataMixingHcalDigiWorkerProd(const edm::ParameterSet &ps,
edm::ConsumesCollector &&iC,
const edm::ESGetToken<HcalDbService, HcalDbRecord> &tok)
: HBHEPileInputTag_(ps.getParameter<edm::InputTag>("HBHEPileInputTag")),
HOPileInputTag_(ps.getParameter<edm::InputTag>("HOPileInputTag")),
HFPileInputTag_(ps.getParameter<edm::InputTag>("HFPileInputTag")),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,9 @@ namespace edm {
class DataMixingHcalDigiWorkerProd {
public:
/** standard constructor*/
explicit DataMixingHcalDigiWorkerProd(const edm::ParameterSet &ps, edm::ConsumesCollector &&iC, const edm::ESGetToken<HcalDbService, HcalDbRecord>&);
explicit DataMixingHcalDigiWorkerProd(const edm::ParameterSet &ps,
edm::ConsumesCollector &&iC,
const edm::ESGetToken<HcalDbService, HcalDbRecord> &);

/**Default destructor*/
virtual ~DataMixingHcalDigiWorkerProd();
Expand Down

0 comments on commit c81ed0a

Please sign in to comment.