Show the average points for the storypoint results #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sedroche
reviewed
Jul 23, 2018
| @@ -64,6 +64,22 @@ export class StoryPointer extends React.Component { | |||
| this.socket.close(); | |||
| } | |||
|
|
|||
| calculateAverage(pointers) { | |||
There was a problem hiding this comment.
I prefer to do things functionally.
const validPointerScore pointer => pointer.score && pointer.score !== '?';
pointers.filter(validPointerScore)
.reduce((total, pointer) => parseInt(total += pointer.score, 10), 0)
There was a problem hiding this comment.
That seems a lot less readable though @sedroche
| @@ -92,10 +109,13 @@ export class StoryPointer extends React.Component { | |||
| let pointers = []; | |||
| if (isNewPointerJoined(data)) { | |||
| pointers = data.points; | |||
| pointers.push({'name': 'Average Points'}); | |||
There was a problem hiding this comment.
Can this be added to the jsx?
There was a problem hiding this comment.
With the way that we're rendering the table and it's content, i don't think it's possible to add another row without adding it to this.state.pointers. We also need to be able to show/clear it.
| } | ||
|
|
||
| if (isScoreUpdated(data)) { | ||
| pointers = this.createUpdatedStoryPoints(data); | ||
| this.calculateAverage(pointers); |
There was a problem hiding this comment.
If we add an average to the jsx this will just become:
this.setState({average: this.calculateAverage(pointers))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an average point row in the storypoint table to show the average points of the scores.