v2.3.1

maltaisn · Mar 1, 2019 · 6dee606 · 6dee606
1 parent 07e7613
commit 6dee606
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+### v2.3.1
+- Prevented ADB bug where category string references weren't changed to an ID.
+
 ## v2.3.0
 - Added dismiss listener.
 - Improved nullity annotations for Kotlin.

diff --git a/icondialog/build.gradle b/icondialog/build.gradle
@@ -14,8 +14,8 @@ ext {
     siteUrl = 'https://github.com/maltaisn/icondialoglib'
     gitUrl = 'https://github.com/maltaisn/icondialoglib.git'
 
-    libraryVersionCode = 11
-    libraryVersion = '2.3.0'
+    libraryVersionCode = 12
+    libraryVersion = '2.3.1'
 
     developerId = 'maltaisn'
 

diff --git a/icondialog/src/main/java/com/maltaisn/icondialog/IconHelper.java b/icondialog/src/main/java/com/maltaisn/icondialog/IconHelper.java
@@ -312,6 +312,8 @@ private synchronized void loadIcons(@XmlRes int xmlFile, boolean append) {
                         int resId = 0;
                         if (nameStr != null) {
                             if (nameStr.startsWith("@string/")) {
+                                // There's an ADB bug where the string reference isn't changed to an ID.
+                                // This detects and prevents it.
                                 resId = context.getResources().getIdentifier(
                                         nameStr.substring(8), "string", context.getPackageName());
                             } else {