-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base on Lumino Application #96
base: main
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 358046667Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Thanks for exploring this. How does this affect the size of the bundle when building in production mode?
Yes it's one of the main advantages of using a lab application, so that adding extensions to the list of plugins "just works". I found it quite convenient for example in this alternative notebook UI that also uses lab components and extensions: In the case of a Lumino app, plugins will be given an It also depends a bit on #92, as part of the JupyterLab application expects a |
Current master:
This branch
The reduction comes mainly from dropping codemirror: |
a6fe03d
to
fdef18b
Compare
Thanks, it's nice to be able to compare the two bundles. It looks like Which depends on Not sure how easy it would be to change that upstream. |
This is a PoC for now.
It will be good to see if it can be made compatible with JLab extensions system so that for example theme can be dynamically installed.