Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add reverse flag to list command #3705
feat: add reverse flag to list command #3705
Changes from 7 commits
97c3d2f
c066f26
34c06d4
4ced0b8
c54fa02
4207ed0
6c4fb53
254e706
022e0e2
4ae186c
29a4643
ef45c80
5a96f3a
c1314b9
8ebdd6f
1bb4ac1
cae3aad
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is maybe beyond this PR because it wasn't done in the first place, but we should test the non
--json
case as well (you could have missed adding the correspondingstd::sort
, and no test would have pointed that...).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a test for the non --json case, but the part checking "conda-forge" is assuming that "res" always has the same format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This handling of flags might be useful to boil down the two tests into a single one handling all the flags.
mamba/micromamba/tests/test_env.py
Lines 74 to 75 in 3dcbf76
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed that IRL, let's forget about my last suggestion (it would make things more complicated than necessary).