sinclair/tsconf.cpp: Changed default ram data to 0x00; cram full init #13823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuavas
reviewed
Jun 14, 2025
src/mame/sinclair/tsconf.cpp
Outdated
Comment on lines
235
to
254
| const u16 cram_init[0x100] = { | ||
| 0x0000, 0x0008, 0x0010, 0x0018, 0x2000, 0x2008, 0x2010, 0x2018, 0x4000, 0x4008, 0x4010, 0x4018, 0x6000, 0x6008, 0x6010, 0x6018, | ||
| 0x0100, 0x0108, 0x0110, 0x0118, 0x2100, 0x2108, 0x2110, 0x2118, 0x4100, 0x4108, 0x4110, 0x4118, 0x6100, 0x6108, 0x6110, 0x6118, | ||
| 0x0200, 0x0208, 0x0210, 0x0218, 0x2200, 0x2208, 0x2210, 0x2218, 0x4200, 0x4208, 0x4210, 0x4218, 0x6200, 0x6208, 0x6210, 0x6218, | ||
| 0x0300, 0x0308, 0x0310, 0x0318, 0x2300, 0x2308, 0x2310, 0x2318, 0x4300, 0x4308, 0x4310, 0x4318, 0x6300, 0x6308, 0x6310, 0x6318, | ||
| 0x0000, 0x0010, 0x4000, 0x4010, 0x0200, 0x0210, 0x4200, 0x4210, 0x2108, 0x0018, 0x6000, 0x6018, 0x0300, 0x0318, 0x6300, 0x6318, | ||
| 0x0000, 0x0010, 0x4000, 0x4010, 0x0200, 0x0210, 0x4200, 0x4210, 0x0000, 0x0018, 0x6000, 0x6018, 0x0300, 0x0318, 0x6300, 0x6318, | ||
| 0x0000, 0x0010, 0x4000, 0x4010, 0x0200, 0x0210, 0x4200, 0x4210, 0x2108, 0x0018, 0x6000, 0x6018, 0x0300, 0x0318, 0x6300, 0x6318, | ||
| 0x0000, 0x0010, 0x4000, 0x4010, 0x0200, 0x0210, 0x4200, 0x4210, 0x0000, 0x0018, 0x6000, 0x6018, 0x0300, 0x0318, 0x6300, 0x6318, | ||
| 0x0000, 0x0010, 0x4000, 0x4010, 0x0200, 0x0210, 0x4200, 0x4210, 0x2108, 0x0018, 0x6000, 0x6018, 0x0300, 0x0318, 0x6300, 0x6318, | ||
| 0x0000, 0x0010, 0x4000, 0x4010, 0x0200, 0x0210, 0x4200, 0x4210, 0x0000, 0x0018, 0x6000, 0x6018, 0x0300, 0x0318, 0x6300, 0x6318, | ||
| 0x0000, 0x0010, 0x4000, 0x4010, 0x0200, 0x0210, 0x4200, 0x4210, 0x2108, 0x0018, 0x6000, 0x6018, 0x0300, 0x0318, 0x6300, 0x6318, | ||
| 0x0000, 0x0010, 0x4000, 0x4010, 0x0200, 0x0210, 0x4200, 0x4210, 0x0000, 0x0018, 0x6000, 0x6018, 0x0300, 0x0318, 0x6300, 0x6318, | ||
| 0x0000, 0x0010, 0x4000, 0x4010, 0x0200, 0x0210, 0x4200, 0x4210, 0x2108, 0x0018, 0x6000, 0x6018, 0x0300, 0x0318, 0x6300, 0x6318, | ||
| 0x0000, 0x0010, 0x4000, 0x4010, 0x0200, 0x0210, 0x4200, 0x4210, 0x0000, 0x0018, 0x6000, 0x6018, 0x0300, 0x0318, 0x6300, 0x6318, | ||
| 0x0000, 0x0010, 0x4000, 0x4010, 0x0200, 0x0210, 0x4200, 0x4210, 0x2108, 0x0018, 0x6000, 0x6018, 0x0300, 0x0318, 0x6300, 0x6318, | ||
| 0x0000, 0x0010, 0x4000, 0x4010, 0x0200, 0x0210, 0x4200, 0x4210, 0x0000, 0x0018, 0x6000, 0x6018, 0x0300, 0x0318, 0x6300, 0x6318 | ||
| }; | ||
| for (auto i = 0; i < 0x100; i++) | ||
| cram_write16(i << 1, (cram_init[i] >> 8) | (cram_init[i] << 8)); // init color RAM |
There was a problem hiding this comment.
Where does this come from? Can you load it as a “ROM” rather than having it in an array here?
There was a problem hiding this comment.
https://github.com/tslabs/zx-evo/blob/master/pentevo/fpga/current/video/mem/video_cram.mif
I'm planning to load it as a ROM eventually, but that requires entire cram refactoring and change it to proper 16bit data size. For now it just patches what we have.
There was a problem hiding this comment.
You don’t need to change the RAM width to load it as a ROM, you could load it as a 16-bit ROM region, and then just do the same thing here, like:
u16 const *const cram_init = &memregion("cram_init")->as_u16();
for (auto i = 0; i < 0x100; i++)
cram_write16(i << 1, (cram_init[i] >> 8) | (cram_init[i] << 8)); // init color RAMor something similar.
There was a problem hiding this comment.
Edited the code fragment in the previous comment. Commenting on three PRs at once is a bad idea.
There was a problem hiding this comment.
It's fine, I'll figure out. It is only required for spg. For regular boot BIOS update palette.
|
here you go |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.