Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use BouncyCastle directly #1928

Closed
wants to merge 2 commits into from
Closed

Use BouncyCastle directly #1928

wants to merge 2 commits into from

Conversation

Karlatemp
Copy link
Member

@Karlatemp Karlatemp commented Mar 13, 2022 •
edited
Loading

  • 统一实现

@Karlatemp Karlatemp requested a review from Him188 March 13, 2022 08:27
@Karlatemp Karlatemp added t:enhancement 类型: 现有功能上的优化 N 优先级: 一般 s:core 子系统: mirai-core labels Mar 13, 2022
@Him188
Copy link
Member

Him188 commented Mar 13, 2022

是不是可以去除 expact/actual?

@Karlatemp
Copy link
Member Author

我不知道ea最开始是为什么加入，翻记录第一班都有ea所以我留着了

@Him188
Copy link
Member

Him188 commented Mar 13, 2022

那就可以去除了

最早用的 Android 内置 BC, 后来不知道为什么用不了了, 不太记得了

@Karlatemp Karlatemp marked this pull request as draft March 13, 2022 15:49
@Him188 Him188 added this to the 2.12 milestone Apr 18, 2022
@Him188 Him188 mentioned this pull request Apr 18, 2022
Open
Him188
Him188 approved these changes Apr 18, 2022
View reviewed changes
Copy link
Member

@Him188 Him188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以先手动测试然后合并，或者等待 #1980

@Him188 Him188 modified the milestones: 2.12, Backlog Apr 18, 2022
@AdoptOSS
Copy link
Contributor

我不知道ea最开始是为什么加入，翻记录第一班都有ea所以我留着了

那就可以去除了

#2048 大概需要ea逻辑，但可能需要重新设计

@Him188
Copy link
Member

Him188 commented May 25, 2022

@AdoptOSS 是的, 现在是 JVM/Android/native, 之后可以变为 jvmBase/native, 如果有必要

@AdoptOSS AdoptOSS mentioned this pull request Jun 30, 2022
Closed
@Him188 Him188 closed this Sep 2, 2023
@Him188 Him188 deleted the core/BouncyCastle branch September 2, 2023 03:26
@Him188 Him188 restored the core/BouncyCastle branch September 2, 2023 03:51
@Him188 Him188 removed this from the Backlog milestone Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Him188 Him188 Him188 approved these changes

Assignees
No one assigned
Labels
N 优先级: 一般 s:core 子系统: mirai-core t:enhancement 类型: 现有功能上的优化
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Karlatemp @Him188 @AdoptOSS