Skip to content

Commit

Permalink
Skip azure compat tests because of #1979
Browse files Browse the repository at this point in the history
Also since 4.5.1 is now available we replace 4.5.0 with 4.5.1 which
should re-enable the lmdb and mongo tests with their segfaults fixed.
  • Loading branch information
IvoDD committed Nov 6, 2024
1 parent 940f2e7 commit 7993f29
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 5 deletions.
6 changes: 4 additions & 2 deletions python/tests/compat/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ def assert_read(self, sym : str, df) -> None:
scope="session",
params=[
pytest.param("1.6.2", marks=VENV_COMPAT_TESTS_MARK),
pytest.param("4.5.0", marks=VENV_COMPAT_TESTS_MARK),
pytest.param("4.5.1", marks=VENV_COMPAT_TESTS_MARK),
] # TODO: Extend this list with other old versions
)
def old_venv(request):
Expand Down Expand Up @@ -176,10 +176,12 @@ def arctic_uri(request):

@pytest.fixture()
def old_venv_and_arctic_uri(old_venv, arctic_uri):
# TODO: Replace 4.5.0 with 4.5.1 when it is released to re-enable both mongo and lmdb.
if Version(old_venv.version) <= Version("4.5.0") and arctic_uri.startswith("mongo"):
pytest.skip("Mongo storage backend has a desctruction bug present until 4.5.0, which can cause flaky segfaults.")
if Version(old_venv.version) <= Version("4.5.0") and arctic_uri.startswith("lmdb"):
pytest.skip("LMDB storage backend has a desctruction bug present until 4.5.0, which can cause flaky segfaults.")
if arctic_uri.startswith("azure"):
# TODO: Once #1979 is understood and fixed reenable azure on versions which have the fix.
pytest.skip("Azure storage backend has probable a desctruction bug, which can cause flaky segfaults.")

return old_venv, arctic_uri
3 changes: 0 additions & 3 deletions python/tests/compat/requirements-4.5.0.txt

This file was deleted.

3 changes: 3 additions & 0 deletions python/tests/compat/requirements-4.5.1.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
arcticdb==4.5.1
numpy<2
pyarrow

0 comments on commit 7993f29

Please sign in to comment.