Includes pybind11/numpy only where it's required #1015
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohanMabille
force-pushed
the
includes
branch
2 times, most recently
from
02417ba to
1072d97
Compare
JohanMabille
force-pushed
the
includes
branch
from
74fc6ad to
9077b95
Compare
JohanMabille
force-pushed
the
includes
branch
from
9077b95 to
da7da5f
Compare
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
Signed-off-by: Julien Jerphanion <[email protected]>
…lue types. Instead of relying on argument deduction and convention over the first template argument, we instead here rely on the standard way to get the value-type of a container or range. Note that this suggests that a concept for Tensor could be helpful here for only compiling valid code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement or fix?
This PR starts to clean up the includes chain to reduce the build time.
Any other comments?
Checklist
Checklist for code changes...