Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Concurrent read, append, compact stress test #1108

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

WIP: Concurrent read, append, compact stress test #1108

wants to merge 2 commits into from

Conversation

joe-iddon
Copy link
Collaborator

@joe-iddon joe-iddon commented Nov 27, 2023 •
edited
Loading

Reference Issues/PRs

What does this implement or fix?

  • Implement a C++ unit test to concurrently read, append, compact and check there are no race coniditions.

Any other comments?

There is a KeyNotFoundException race condition which still needs to be fixed. The libprotobuf error has not shown up yet.

I've attached an example output from the unit test:
example_unit_test_output.txt

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

@joe-iddon joe-iddon force-pushed the atomic_version_map_update branch from 79ca969 to 69cb6c6 Compare December 6, 2023 09:58
Base automatically changed from atomic_version_map_update to master December 8, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexowens90 alexowens90 Awaiting requested review from alexowens90 alexowens90 will be requested when the pull request is marked ready for review alexowens90 is a code owner

@willdealtry willdealtry Awaiting requested review from willdealtry willdealtry will be requested when the pull request is marked ready for review willdealtry is a code owner

@poodlewars poodlewars Awaiting requested review from poodlewars poodlewars will be requested when the pull request is marked ready for review poodlewars is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
replicated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joe-iddon @maxim-morozov