Prechecks for asv #2107
+235
−43
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| name: Run ASV Tests Check Python Script | ||
|
|
||
| on: | ||
| push: | ||
| branches-ignore: | ||
| - 'master' | ||
| paths: | ||
| - 'python/benchmarks/**' | ||
| - 'python/.asv/results/**' | ||
| - 'asv.conf.json' | ||
| pull_request: | ||
| branches-ignore: | ||
| - 'master' | ||
| paths: | ||
| - 'python/benchmarks/**' | ||
| - 'python/.asv/results/**' | ||
| - 'asv.conf.json' | ||
|
|
||
| jobs: | ||
| run-asv-check-script: | ||
|
There was a problem hiding this comment. I agree with @IvoDD,we don't need this to be a separate flow, just a separate job in the analysis_flow. There was a problem hiding this comment. agree makes lots of sence There was a problem hiding this comment. |
||
| timeout-minutes: 30 | ||
| runs-on: ubuntu-latest | ||
| container: ghcr.io/man-group/arcticdb-dev:latest | ||
| defaults: | ||
| run: {shell: bash} | ||
| steps: | ||
| - uses: actions/[email protected] | ||
| with: | ||
| lfs: 'true' | ||
| fetch-depth: 0 | ||
| submodules: recursive | ||
| token: ${{ secrets.ARCTICDB_TEST_PAT }} | ||
| ref: ${{ github.event.pull_request.head.sha }} | ||
|
|
||
| - name: Install ASV | ||
| shell: bash -el {0} | ||
| run: | | ||
| git config --global --add safe.directory . | ||
| python -m pip install --upgrade pip | ||
| pip install asv | ||
|
|
||
| - name: Run ASV Tests Check script | ||
| run: | | ||
| python python/utils/asv_checks.py | ||
| continue-on-error: false | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if you call this "ASV Linting" or something it will be more obvious to people that it doesn't actually run the benchmarks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, but note that this does something additional as check of versions of benchmark tests ... see bellow