Storage mover port (#2039) #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!--Example: Fixes #1234. See also #3456.--> Add the StorageMover class from arcticc. Some changes in the implementation of the StorageMover were needed as `batch_read_compressed` used to return not only the keys but the segments as well. In the current ArcticDB version the segment is passed as continuation and that required keeping additional vector where the segments themselves are stored. Make sure all unit tests are passing. No changes to the API are done. Note in arcticc it was in the tools module while here it's in the toolbox module. <details> <summary> Checklist for code changes... </summary> - [ ] Have you updated the relevant docstrings, documentation and copyright notice? - [ ] Is this contribution tested against [all ArcticDB's features](../docs/mkdocs/docs/technical/contributing.md)? - [ ] Do all exceptions introduced raise appropriate [error messages](https://docs.arcticdb.io/error_messages/)? - [ ] Are API changes highlighted in the PR description? - [ ] Is the PR labelled as enhancement or bug so it appears in autogenerated release notes? </details> <!-- Thanks for contributing a Pull Request to ArcticDB! Please ensure you have taken a look at: - ArcticDB's Code of Conduct: https://github.com/man-group/ArcticDB/blob/master/CODE_OF_CONDUCT.md - ArcticDB's Contribution Licensing: https://github.com/man-group/ArcticDB/blob/master/docs/mkdocs/docs/technical/contributing.md#contribution-licensing -->
vasil-pashov
requested review from
alexowens90,
willdealtry and
poodlewars
as code owners
alexowens90
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the StorageMover class from arcticc. Some changes in the implementation of the StorageMover were needed as
batch_read_compressedused to return not only the keys but the segments as well. In the current ArcticDB version the segment is passed as continuation and that required keeping additional vector where the segments themselves are stored.Make sure all unit tests are passing.
No changes to the API are done.
Note in arcticc it was in the tools module while here it's in the toolbox module.
Checklist for code changes...
Reference Issues/PRs
What does this implement or fix?
Any other comments?
Checklist
Checklist for code changes...