Add a blocking task executor so that we can easily bound the number of tasks kept live in memory at once #2136
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply it to the finalize_staged_data process as a first example.
There are simpler ways to implement this in
do_compact
specifically (like completing a future before submitting a new one), and other places in the code usefolly::window
to do this, but this gives us a good way to handle these problems in a cross-cutting way. We might want to use the blocking queue more widely if this is successful.This helped to reduce the memory used by
finalize_staged_data
with write delays, I'm going to do some more benchmarking then share the results here.Monday: 8234437666