Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP Enhancement 8277989680: symbol concatenation poc #2142

Draft
wants to merge 36 commits into
base: master
Choose a base branch
from
Draft

WIP Enhancement 8277989680: symbol concatenation poc #2142

wants to merge 36 commits into from

Conversation

alexowens90
Copy link
Collaborator

Reference Issues/PRs

8277989680

What does this implement or fix?

Implement basic POC of symbol concatenation. Known limitations:

  • TODO - fill this in

Any other comments?

Checklist

Checklist for code changes...
  • Have you updated the relevant docstrings, documentation and copyright notice?
  • Is this contribution tested against all ArcticDB's features?
  • Do all exceptions introduced raise appropriate error messages?
  • Are API changes highlighted in the PR description?
  • Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

@alexowens90
Minimal class and methods defined
e4d94e3
@alexowens90
Remove C++ changes
cc89694
@alexowens90
Reworked Python layer
b533622
@alexowens90
Revert whitespace change
28eda08
@alexowens90
Sketch out API for reading multiple symbols with a joi
e71b5eb
@alexowens90
Wiring down to local_version_engine.cpp
08126c3
@alexowens90
Use Poly Clause from VersionStoreApi level downwards
d9107e5
@alexowens90
Batch read and get set of entity IDs on a single ComponentManager for…
634247a 
… all individual symbol queries (untested)
@alexowens90
Fix schedule_clause_processing when there are zero clauses
4aafe67
@alexowens90
Produce one SegmentInMemory from output of multiple symbol's pipelines
ec189c7
@alexowens90
First, most basic, test passing
b5e10a0
@alexowens90
Refactor schedule_remaining_iterations into own method
400facf
@alexowens90
Added ConcatClause
82b2290
@alexowens90
Fix ConcatClause::structure_for_processing
727cd34
@alexowens90
First end-to-end test passing!
139f3af
@alexowens90 alexowens90 marked this pull request as draft January 27, 2025 10:02
@alexowens90 alexowens90 self-assigned this Jan 27, 2025
@alexowens90 alexowens90 added the enhancement New feature or request label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willdealtry willdealtry Awaiting requested review from willdealtry willdealtry is a code owner

@poodlewars poodlewars Awaiting requested review from poodlewars poodlewars is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@alexowens90 alexowens90

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alexowens90