DBA tools for ReliableStorageLock #2152
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the options to: - inspect latest state of the lock - force take or free the lock. This is done by not respecting the expiration and jumping a few ids forward. Also adds a C++ test to verify the new APIs work as expected. The APIs will be exposed for use in arcticdb-enterprise.
IvoDD
force-pushed
the
storage-lock-admin-tools
branch
from
f120b23 to
a6ca0cf
Compare
I'll be using the MockS3Client in enterprise replication testing and it needs to be thread safe to be used correctly. Also adds a segment size calculation which is necassary for the `CopyCompressedInterStoreTask`
Cloning did not copy over all fields. The `MockS3Storage` relies on cloning segments and this makes it usable for all cases.
IvoDD
force-pushed
the
storage-lock-admin-tools
branch
from
12d70c3 to
ff22094
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the options to:
Also adds a C++ test to verify the new APIs work as expected.
The APIs will be exposed for use in arcticdb-enterprise.
Also in two separate commits it improves the
MockS3Clientto be usable in enterprise replication tests. Can be reviewed separately:MockS3Clientthread safeSegmentHeader::clone()Reference Issues/PRs
Related to 8013103642 monday ticket
What does this implement or fix?
Any other comments?
Checklist
Checklist for code changes...