-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emscripten #130
base: main
Are you sure you want to change the base?
Emscripten #130
Conversation
DerThorsten
commented
Jul 2, 2024
- emscripten build / workflow
include/sparrow/typed_array.hpp
Outdated
@@ -467,7 +467,7 @@ namespace sparrow | |||
bool operator==(const typed_array<T, Layout>& ta1, const typed_array<T, Layout>& ta2) | |||
{ | |||
// see https://github.com/man-group/sparrow/issues/108 | |||
#if defined(_LIBCPP_VERSION) && (_LIBCPP_VERSION < 180000) | |||
#if EMSCRIPTEN ||( defined(_LIBCPP_VERSION) && (_LIBCPP_VERSION < 180000)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible that you won't need that if <version>
is included.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think it's better to not have this check (also it should be defined(EMSCRIPTEN)
?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this was removed and re-added. Can we confirm that it works without this check if <version>
is included?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried with including version 19cb95b but this failed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah it seems that _LIBCPP_VERSION is not defined with Emscripten.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm ok then EMSCRIPTEN
is probably the right define do check I suppose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know if a clang18-based emscripten would also require this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know if a clang18-based emscripten would also require this?
we don't know. Atm we use the emscripten version of emscripten-forge (3.1.45).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's only to know if there should be an upper bound in these checks.
atm still all timezone tests fail with:
This is why I currently filter out these tests with:
|
-DBUILD_TESTS=ON \ | ||
.. | ||
|
||
emmake make -j9 install |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why j9 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...leftover from copy/pasting
@@ -7,8 +7,11 @@ dependencies: | |||
- ninja | |||
# Tests | |||
- doctest | |||
# Wasm Tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to have a condition to not get nodejs if we don't use emscripten ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could introduce install node at runtime in the ci