Emscripten

[DerThorsten]

• emscripten build / workflow

[SylvainCorlay]

It's possible that you won't need that if <version> is included.

[Klaim]

Yes I think it's better to not have this check (also it should be defined(EMSCRIPTEN)?)

[SylvainCorlay]

It seems this was removed and re-added. Can we confirm that it works without this check if <version> is included?

[DerThorsten]

I tried with including version 19cb95b but this failed

[SylvainCorlay]

Ah it seems that _LIBCPP_VERSION is not defined with Emscripten.

[Klaim]

Hmm ok then EMSCRIPTEN is probably the right define do check I suppose.

[SylvainCorlay]

Do we know if a clang18-based emscripten would also require this?

[DerThorsten]

Do we know if a clang18-based emscripten would also require this?

we don't know. Atm we use the emscripten version of emscripten-forge (3.1.45).

[SylvainCorlay]

It's only to know if there should be an upper bound in these checks.

[DerThorsten]

atm still all timezone tests fail with:

===============================================================================
/Users/thorstenbeier/src/sparrow/test/test_typed_array_timestamp.cpp:41:
TEST SUITE: typed_array_timestamp
TEST CASE:  constructor with parameter

/Users/thorstenbeier/src/sparrow/test/test_typed_array_timestamp.cpp:41: ERROR: test case THREW exception: discover_tz_dir failed to find zoneinfo


===============================================================================

This is why I currently filter out these tests with:

node build/test/test_sparrow_lib.js -tse=typed_array_timestamp 

[Alex-PLACET]

why j9 ?

[DerThorsten]

...leftover from copy/pasting

[Alex-PLACET]

Is it possible to have a condition to not get nodejs if we don't use emscripten ?

[DerThorsten]

we could introduce install node at runtime in the ci