Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAP preflight mode #1

Merged
merged 4 commits into from
Jan 23, 2024
Merged

DAP preflight mode #1

merged 4 commits into from
Jan 23, 2024

Conversation

mverzilli
Copy link

Internal PR for internal review and internal evaluation :P

@mverzilli mverzilli requested a review from ggiraldez January 18, 2024 15:04
Copy link
Member

@ggiraldez ggiraldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tooling/nargo_cli/src/cli/dap_cmd.rs Outdated Show resolved Hide resolved
tooling/nargo_cli/src/cli/dap_cmd.rs Show resolved Hide resolved
@mverzilli mverzilli marked this pull request as ready for review January 23, 2024 16:38
@mverzilli mverzilli merged commit b0ee08c into dap-with-vars Jan 23, 2024
14 of 17 checks passed
ggiraldez pushed a commit that referenced this pull request Jan 24, 2024
* DAP preflight mode

* Properly handle generate_acir and skip_instrumentation

* Add more context on preflight mode
ggiraldez pushed a commit that referenced this pull request Jan 26, 2024
* DAP preflight mode

* Properly handle generate_acir and skip_instrumentation

* Add more context on preflight mode
ggiraldez pushed a commit that referenced this pull request Feb 5, 2024
* DAP preflight mode

* Properly handle generate_acir and skip_instrumentation

* Add more context on preflight mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants