Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(debugger): REPL add breakpoint by sourcecode line #2

Conversation

anaPerezGhiglia
Copy link
Member

@anaPerezGhiglia anaPerezGhiglia commented Jun 4, 2024

Observations 👀

  • This PR base branch is a master-like MANAS-project branch (a separate branch which HEAD points to master)
  • The intention is to have an internal review first, and if approved & merged I can open a PR in noir's repo from the base branch of this PR

Description

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

* print added breakpoint at line
* simplify get_current_file implementation
Copy link

github-actions bot commented Jun 4, 2024

Thank you for your contribution to the Noir language.

Please do not force push to this branch after the Noir team have started review of this PR. Doing so will only delay us merging your PR as we will need to start the review process from scratch.

Thanks for your understanding.

@anaPerezGhiglia anaPerezGhiglia changed the title Feat (debugger): REPL add breakpoint by sourcecode line feat(debugger): REPL add breakpoint by sourcecode line Jun 4, 2024
@mverzilli
Copy link

I only made one comment about a match that could be re-written as a map, the rest looks great 🙌

@anaPerezGhiglia anaPerezGhiglia merged commit e837add into feat/debug-repl-add-breakpoint Jun 7, 2024
38 checks passed
@anaPerezGhiglia anaPerezGhiglia deleted the feat/debugger-repl-sourcecode-breakpoint branch June 7, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants