Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comps groups are shown with their internal ID as the name #3

Closed
kkofler opened this issue Nov 15, 2016 · 1 comment
Closed

Comps groups are shown with their internal ID as the name #3

kkofler opened this issue Nov 15, 2016 · 1 comment

Comments

@kkofler
Copy link
Contributor

kkofler commented Nov 15, 2016

Using revision bb6edcf.

The comps groups are shown only with their internal IDs in lieu of names. The user-displayable names are found in gl[1], but the code retains only gl[0], which is the ID.

Note that for categories, we get something more user-centric because dnfdaemon returns the name instead of the id in gl[0] (which causes other problems, see also #2 and manatools/dnfdaemon#9 ), but we still want gl[1], which is the ui_name.

The ui_name (gl[1]) should also be returned in already translated form, but this is not currently happening, I have not checked yet why. (Maybe you have to ask the session daemon rather than the system daemon for the groups? Maybe you should set the locale somewhere?)
kkofler added a commit to kkofler/dnfdragora that referenced this issue Nov 16, 2016
@kkofler
Improve comps group support
072b4bc 
New file dnfdragora/compsicons.py, similar to groupicons.py, but for
comps.

New tool tools/gen-comps-category-list.sh: Generates a map from category
name to ID for dnfdragora/compsicons.py, as a workaround for
manatools/dnfdaemon#9.

dnfdragora/ui.py (mainGui._getAllGroupIDList): Remember the UI names for
                                               each ID in an
                                               id_to_name_map.
                 (mainGui._fillGroupTree): Handle comps separately, use
                                           compsicons.py to get the
                                           icons (manatools#2) and use the
                                           id_to_name_map to get the UI
                                           name (manatools#3).

Fixes manatools#2.
Fixes manatools#3.
kkofler added a commit to kkofler/dnfdragora that referenced this issue Nov 16, 2016
@kkofler
Improve comps group support
7e7d903 
New file dnfdragora/compsicons.py, similar to groupicons.py, but for
comps.

New tool tools/gen-comps-category-list.sh: Generates a map from category
name to ID for dnfdragora/compsicons.py, as a workaround for
manatools/dnfdaemon#9.

dnfdragora/ui.py (mainGui._getAllGroupIDList): Remember the UI names for
                                               each ID in an
                                               id_to_name_map.
                 (mainGui._fillGroupTree): Handle comps separately, use
                                           compsicons.py to get the
                                           icons (manatools#2) and use the
                                           id_to_name_map to get the UI
                                           name (manatools#3).

Fixes manatools#2.
Fixes manatools#3.

The only remaining issue is that the UI names are not translated, which
I filed as manatools/dnfdaemon#10 because Yumex-DNF is also affected (and
thus it is clearly dnfdaemon's fault).
@kkofler
Copy link
Contributor Author

kkofler commented Nov 16, 2016

The ui_name (gl[1]) should also be returned in already translated form, but this is not currently happening, I have not checked yet why. (Maybe you have to ask the session daemon rather than the system daemon for the groups? Maybe you should set the locale somewhere?)

Yumex-DNF has the same issue, so I filed manatools/dnfdaemon#10 for that issue.

@kkofler kkofler mentioned this issue Nov 16, 2016
Merged
Conan-Kudo pushed a commit that referenced this issue Nov 16, 2016
@kkofler @Conan-Kudo
Improve comps group support
1e34f1a 
New file dnfdragora/compsicons.py, similar to groupicons.py, but for
comps.

New tool tools/gen-comps-category-list.sh: Generates a map from category
name to ID for dnfdragora/compsicons.py, as a workaround for
manatools/dnfdaemon#9.

dnfdragora/ui.py (mainGui._getAllGroupIDList): Remember the UI names for
                                               each ID in an
                                               id_to_name_map.
                 (mainGui._fillGroupTree): Handle comps separately, use
                                           compsicons.py to get the
                                           icons (#2) and use the
                                           id_to_name_map to get the UI
                                           name (#3).

Fixes #2.
Fixes #3.

The only remaining issue is that the UI names are not translated, which
I filed as manatools/dnfdaemon#10 because Yumex-DNF is also affected (and
thus it is clearly dnfdaemon's fault).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kkofler