Improve comps group support #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New file dnfdragora/compsicons.py, similar to groupicons.py, but for comps. New tool tools/gen-comps-category-list.sh: Generates a map from category name to ID for dnfdragora/compsicons.py, as a workaround for manatools/dnfdaemon#9. dnfdragora/ui.py (mainGui._getAllGroupIDList): Remember the UI names for each ID in an id_to_name_map. (mainGui._fillGroupTree): Handle comps separately, use compsicons.py to get the icons (manatools#2) and use the id_to_name_map to get the UI name (manatools#3). Fixes manatools#2. Fixes manatools#3. The only remaining issue is that the UI names are not translated, which I filed as manatools/dnfdaemon#10 because Yumex-DNF is also affected (and thus it is clearly dnfdaemon's fault).
Conan-Kudo
approved these changes
Nov 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New file dnfdragora/compsicons.py, similar to groupicons.py, but for comps.
New tool tools/gen-comps-category-list.sh: Generates a map from category name to ID for dnfdragora/compsicons.py, as a workaround for manatools/dnfdaemon#9.
dnfdragora/ui.py (mainGui._getAllGroupIDList): Remember the UI names for each ID in an
id_to_name_map.(mainGui._fillGroupTree): Handle comps separately, use compsicons.py to get the icons (#2) and use the
id_to_name_mapto get the UI name (#3).Fixes #2.
Fixes #3.
The only remaining issue is that the UI names are not translated, which I filed as manatools/dnfdaemon#10 because Yumex-DNF is also affected (and thus it is clearly dnfdaemon's fault).